Don't register view container if we know it will be hidden (microsoft#232309)

just skip the registration if we have state to hide
keep keybinding

Author: sbatten

src/vs/workbench/contrib/chat/browser/chatMovedView.contribution.ts

@@ -61,9 +61,18 @@ export class MoveChatViewContribution implements IWorkbenchContribution {
 	}
 
 	private async initialize(): Promise<void> {
+		const hidden = this.storageService.getBoolean(MoveChatViewContribution.hideMovedChatWelcomeViewStorageKey, StorageScope.APPLICATION, false);
+
+		// If the view is already hidden, then we just want to register keybindings.
+		if (hidden) {
+			this.registerKeybindings();
+			return;
+		}
+
 		await this.hideViewIfCopilotIsNotInstalled();
 		this.updateContextKey();
 		this.registerListeners();
+		this.registerKeybindings();
 		this.registerCommands();
 		this.registerMovedChatWelcomeView();
 		this.hideViewIfOldViewIsMovedFromDefaultLocation();
@@ -116,15 +125,17 @@ export class MoveChatViewContribution implements IWorkbenchContribution {
 		this.storageService.onDidChangeValue(StorageScope.APPLICATION, MoveChatViewContribution.hideMovedChatWelcomeViewStorageKey, new DisposableStore())(() => this.updateContextKey());
 	}
 
-	private registerCommands(): void {
+	private registerKeybindings(): void {
 		KeybindingsRegistry.registerCommandAndKeybindingRule({
 			id: CHAT_SIDEBAR_OLD_VIEW_PANEL_ID,
 			weight: KeybindingWeight.WorkbenchContrib,
 			when: CONTEXT_CHAT_PANEL_PARTICIPANT_REGISTERED,
 			primary: 0,
 			handler: accessor => showChatView(accessor.get(IViewsService))
 		});
+	}
 
+	private registerCommands(): void {
 		CommandsRegistry.registerCommand({
 			id: '_chatMovedViewWelcomeView.ok',
 			handler: async (accessor: ServicesAccessor) => {