Remove 'name' on tool result part, and fix note about PromptElement tool results (microsoft#226500)

* Remove 'name' on tool result part, and fix note about PromptElement tool results

* More names

Author: roblourens

src/vs/workbench/api/common/extHostTypeConverters.ts

@@ -2317,7 +2317,7 @@ export namespace LanguageModelChatMessage {
 			if (c.type === 'text') {
 				return c.value;
 			} else {
-				return new types.LanguageModelToolResultPart(c.name, c.name, c.value, c.isError);
+				return new types.LanguageModelToolResultPart(c.toolCallId, c.value, c.isError);
 			}
 		});
 		const content = content2.find(c => typeof c === 'string') ?? '';
@@ -2336,7 +2336,6 @@ export namespace LanguageModelChatMessage {
 			if (message.content2 instanceof types.LanguageModelToolResultPart) {
 				return {
 					type: 'tool_result',
-					name: message.content2.name,
 					toolCallId: message.content2.toolCallId,
 					value: message.content2.content,
 					isError: message.content2.isError

src/vs/workbench/api/common/extHostTypes.ts

@@ -4559,13 +4559,11 @@ export enum LanguageModelChatMessageRole {
 
 export class LanguageModelToolResultPart implements vscode.LanguageModelChatMessageToolResultPart {
 
-	name: string;
 	toolCallId: string;
 	content: string;
 	isError: boolean;
 
-	constructor(name: string, toolCallId: string, content: string, isError?: boolean) {
-		this.name = name;
+	constructor(toolCallId: string, content: string, isError?: boolean) {
 		this.toolCallId = toolCallId;
 		this.content = content;
 		this.isError = isError ?? false;

src/vs/workbench/contrib/chat/common/languageModels.ts

@@ -29,7 +29,6 @@ export interface IChatMessageTextPart {
 
 export interface IChatMessageToolResultPart {
 	type: 'tool_result';
-	name: string;
 	toolCallId: string;
 	value: any;
 	isError?: boolean;

src/vscode-dts/vscode.proposed.lmTools.d.ts

@@ -52,12 +52,11 @@ declare module 'vscode' {
 
 	// USER -> LM: the result of a function call
 	export class LanguageModelChatMessageToolResultPart {
-		name: string;
 		toolCallId: string;
 		content: string;
 		isError: boolean;
 
-		constructor(name: string, toolCallId: string, content: string, isError?: boolean);
+		constructor(toolCallId: string, content: string, isError?: boolean);
 	}
 
 	export interface LanguageModelChatMessage {
@@ -74,7 +73,7 @@ declare module 'vscode' {
 
 	export interface LanguageModelToolResult {
 		/**
-		 * The result can contain arbitrary representations of the content. An example might be 'prompt-tsx' to indicate an element that can be rendered with the @vscode/prompt-tsx library.
+		 * The result can contain arbitrary representations of the content. An example might be a `PromptElementJSON` from `@vscode/prompt-tsx`, using the `contentType` exported by that library.
 		 */
 		[contentType: string]: any;