Merge branch 'main' into traffic-lights-position

Author: stephen-ullom

package.json

@@ -98,7 +98,7 @@
   },
   "devDependencies": {
     "7zip": "0.0.6",
-    "@playwright/test": "1.26.0",
+    "@playwright/test": "1.27.1",
     "@swc/cli": "0.1.57",
     "@swc/core": "1.2.245",
     "@types/cookie": "^0.3.3",

src/vs/editor/common/diff/algorithms/joinSequenceDiffs.ts

@@ -0,0 +1,46 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import { ISequence, OffsetRange, SequenceDiff } from 'vs/editor/common/diff/algorithms/diffAlgorithm';
+
+/**
+ * This function fixes issues like this:
+ * ```
+ * import { Baz, Bar } from "foo";
+ * ```
+ * <->
+ * ```
+ * import { Baz, Bar, Foo } from "foo";
+ * ```
+ * Computed diff: [ {Add "," after Bar}, {Add "Foo " after space} }
+ * Improved diff: [{Add ", Foo" after Bar}]
+ */
+export function joinSequenceDiffs(sequence1: ISequence, sequence2: ISequence, sequenceDiffs: SequenceDiff[]): SequenceDiff[] {
+	const result: SequenceDiff[] = [];
+	if (sequenceDiffs.length > 0) {
+		result.push(sequenceDiffs[0]);
+	}
+
+	for (let i = 1; i < sequenceDiffs.length; i++) {
+		const lastResult = result[result.length - 1];
+		const cur = sequenceDiffs[i];
+
+		if (cur.seq1Range.start - lastResult.seq1Range.endExclusive === 1) {
+			if (cur.seq1Range.isEmpty) {
+				if (sequence2.getElement(cur.seq2Range.start - 1) === sequence2.getElement(cur.seq2Range.endExclusive - 1)) {
+					result[result.length - 1] = new SequenceDiff(lastResult.seq1Range, new OffsetRange(
+						lastResult.seq2Range.start,
+						cur.seq2Range.endExclusive - 1
+					));
+					continue;
+				}
+			}
+		}
+
+		result.push(cur);
+	}
+
+	return result;
+}

src/vs/editor/common/diff/standardLinesDiffComputer.ts

@@ -8,6 +8,7 @@ import { Position } from 'vs/editor/common/core/position';
 import { Range } from 'vs/editor/common/core/range';
 import { SequenceFromIntArray, OffsetRange, SequenceDiff, ISequence } from 'vs/editor/common/diff/algorithms/diffAlgorithm';
 import { DynamicProgrammingDiffing } from 'vs/editor/common/diff/algorithms/dynamicProgrammingDiffing';
+import { joinSequenceDiffs } from 'vs/editor/common/diff/algorithms/joinSequenceDiffs';
 import { MyersDiffAlgorithm } from 'vs/editor/common/diff/algorithms/myersDiffAlgorithm';
 import { ILinesDiff, ILinesDiffComputer, ILinesDiffComputerOptions, LineRange, LineRangeMapping, RangeMapping } from 'vs/editor/common/diff/linesDiffComputer';
 
@@ -108,7 +109,8 @@ export class StandardLinesDiffComputer implements ILinesDiffComputer {
 		const sourceSlice = new Slice(originalLines, diff.seq1Range);
 		const targetSlice = new Slice(modifiedLines, diff.seq2Range);
 
-		const diffs = this.myersDiffingAlgorithm.compute(sourceSlice, targetSlice);
+		const originalDiffs = this.myersDiffingAlgorithm.compute(sourceSlice, targetSlice);
+		const diffs = joinSequenceDiffs(sourceSlice, targetSlice, originalDiffs);
 		const result = diffs.map(
 			(d) =>
 				new RangeMapping(

src/vs/editor/test/common/diff/standardLinesDiffCompute.test.ts

@@ -85,8 +85,7 @@ suite('standardLinesDiffCompute', () => {
 				{
 					main: "{[5,6)->[5,8)}",
 					inner: [
-						"{[5,41 -> 5,41]->[5,41 -> 5,42]}",
-						"{[6,1 -> 6,1]->[6,1 -> 8,1]}",
+						"{[5,41 -> 5,41]->[5,41 -> 7,28]}"
 					]
 				}
 			]

src/vs/platform/action/common/action.ts

@@ -72,9 +72,6 @@ export interface ICommandAction {
 	 * or define toggle-info including an icon and a title that goes well with a checkmark.
 	 */
 	toggled?: ContextKeyExpression | ICommandActionToggleInfo;
-
-	/** @deprecated see https://github.com/microsoft/vscode/issues/162004 */
-	_isFakeAction?: true;
 }
 
 export type ISerializableCommandAction = UriDto<ICommandAction>;

src/vs/platform/actions/common/actions.ts

@@ -556,13 +556,6 @@ interface IAction2CommonOptions extends ICommandAction {
 	 * showing keybindings that have no other UX.
 	 */
 	description?: ICommandHandlerDescription;
-
-	/**
-	 * @deprecated workaround added for https://github.com/microsoft/vscode/issues/162004
-	 * This action doesn't do anything is just a workaround for rendering "something"
-	 * inside a specific toolbar
-	 */
-	_isFakeAction?: true;
 }
 
 interface IBaseAction2Options extends IAction2CommonOptions {

src/vs/platform/actions/common/menuService.ts

@@ -228,8 +228,7 @@ class MenuInfo {
 					const menuHide = createMenuHide(this._id, isMenuItem ? item.command : item, this._hiddenStates);
 					if (isMenuItem) {
 						// MenuItemAction
-						const actualMenuHide = item.command._isFakeAction ? undefined : menuHide;
-						activeActions.push(new MenuItemAction(item.command, item.alt, options, actualMenuHide, this._contextKeyService, this._commandService));
+						activeActions.push(new MenuItemAction(item.command, item.alt, options, menuHide, this._contextKeyService, this._commandService));
 
 					} else {
 						// SubmenuItemAction

src/vs/workbench/contrib/mergeEditor/browser/model/mergeEditorModel.ts

@@ -16,7 +16,7 @@ import { LineRange } from 'vs/workbench/contrib/mergeEditor/browser/model/lineRa
 import { DetailedLineRangeMapping, DocumentLineRangeMap, DocumentRangeMap, LineRangeMapping } from 'vs/workbench/contrib/mergeEditor/browser/model/mapping';
 import { TextModelDiffChangeReason, TextModelDiffs, TextModelDiffState } from 'vs/workbench/contrib/mergeEditor/browser/model/textModelDiffs';
 import { leftJoin } from 'vs/workbench/contrib/mergeEditor/browser/utils';
-import { ModifiedBaseRange, ModifiedBaseRangeState } from './modifiedBaseRange';
+import { ModifiedBaseRange, ModifiedBaseRangeState, ModifiedBaseRangeStateKind } from './modifiedBaseRange';
 
 export interface InputData {
 	readonly textModel: ITextModel;
@@ -41,7 +41,7 @@ export class MergeEditorModel extends EditorModel {
 				this.modifiedBaseRanges.read(reader).map((s) => [
 					s,
 					{
-						accepted: observableValue(`BaseRangeState${s.baseRange}`, ModifiedBaseRangeState.default),
+						accepted: observableValue(`BaseRangeState${s.baseRange}`, ModifiedBaseRangeState.base),
 						handled: observableValue(`BaseRangeHandledState${s.baseRange}`, false),
 					}
 				])
@@ -105,7 +105,7 @@ export class MergeEditorModel extends EditorModel {
 								shouldRecomputeHandledFromAccepted = false;
 								for (const [_range, observableState] of states) {
 									const state = observableState.accepted.get();
-									observableState.handled.set(!(state.isEmpty || state.conflicting), tx);
+									observableState.handled.set(!(state.kind === ModifiedBaseRangeStateKind.base || state.kind === ModifiedBaseRangeStateKind.unrecognized), tx);
 								}
 							}
 						});
@@ -132,13 +132,13 @@ export class MergeEditorModel extends EditorModel {
 				let newState: ModifiedBaseRangeState;
 				let handled = false;
 				if (range.input1Diffs.length === 0) {
-					newState = ModifiedBaseRangeState.default.withInput2(true);
+					newState = ModifiedBaseRangeState.base.withInputValue(2, true);
 					handled = true;
 				} else if (range.input2Diffs.length === 0) {
-					newState = ModifiedBaseRangeState.default.withInput1(true);
+					newState = ModifiedBaseRangeState.base.withInputValue(1, true);
 					handled = true;
 				} else {
-					newState = ModifiedBaseRangeState.default;
+					newState = ModifiedBaseRangeState.base;
 					handled = false;
 				}
 
@@ -335,7 +335,7 @@ export class MergeEditorModel extends EditorModel {
 
 	private computeState(baseRange: ModifiedBaseRange, conflictingDiffs: DetailedLineRangeMapping[]): ModifiedBaseRangeState {
 		if (conflictingDiffs.length === 0) {
-			return ModifiedBaseRangeState.default;
+			return ModifiedBaseRangeState.base;
 		}
 		const conflictingEdits = conflictingDiffs.map((d) => d.getLineEdit());
 
@@ -348,15 +348,15 @@ export class MergeEditorModel extends EditorModel {
 		}
 
 		if (editsAgreeWithDiffs(baseRange.input1Diffs)) {
-			return ModifiedBaseRangeState.default.withInput1(true);
+			return ModifiedBaseRangeState.base.withInputValue(1, true);
 		}
 		if (editsAgreeWithDiffs(baseRange.input2Diffs)) {
-			return ModifiedBaseRangeState.default.withInput2(true);
+			return ModifiedBaseRangeState.base.withInputValue(2, true);
 		}
 
 		const states = [
-			ModifiedBaseRangeState.default.withInput1(true).withInput2(true),
-			ModifiedBaseRangeState.default.withInput2(true).withInput1(true),
+			ModifiedBaseRangeState.base.withInputValue(1, true).withInputValue(2, true),
+			ModifiedBaseRangeState.base.withInputValue(2, true).withInputValue(1, true),
 		];
 
 		for (const s of states) {
@@ -371,7 +371,7 @@ export class MergeEditorModel extends EditorModel {
 			}
 		}
 
-		return ModifiedBaseRangeState.conflicting;
+		return ModifiedBaseRangeState.unrecognized;
 	}
 
 	public getState(baseRange: ModifiedBaseRange): IObservable<ModifiedBaseRangeState> {
@@ -429,8 +429,8 @@ export class MergeEditorModel extends EditorModel {
 			/** @description Reset Unknown Base Range States */
 			this.resultTextModel.pushStackElement();
 			for (const range of this.modifiedBaseRanges.get()) {
-				if (this.getState(range).get().conflicting) {
-					this.setState(range, ModifiedBaseRangeState.default, false, tx, false);
+				if (this.getState(range).get().kind === ModifiedBaseRangeStateKind.unrecognized) {
+					this.setState(range, ModifiedBaseRangeState.base, false, tx, false);
 				}
 			}
 			this.resultTextModel.pushStackElement();
@@ -515,7 +515,7 @@ export class MergeEditorModel extends EditorModel {
 			resultStartLineNumber = resultRange.endLineNumberExclusive;
 
 			outputLines.push('<<<<<<<');
-			if (state.accepted.get().conflicting) {
+			if (state.accepted.get().kind === ModifiedBaseRangeStateKind.unrecognized) {
 				// to prevent loss of data, use modified result as "ours"
 				appendLinesToResult(resultLines, resultRange);
 			} else {