Add http.proxyKerberosServicePrincipal setting (microsoft#187456)

Author: chrmarti

src/vs/platform/request/common/request.ts

@@ -148,6 +148,11 @@ function registerProxyConfigurations(scope: ConfigurationScope): void {
 				description: localize('strictSSL', "Controls whether the proxy server certificate should be verified against the list of supplied CAs."),
 				restricted: true
 			},
+			'http.proxyKerberosServicePrincipal': {
+				type: 'string',
+				markdownDescription: localize('proxyKerberosServicePrincipal', "Overrides the principal service name for Kerberos authentication with the HTTP proxy. A default based on the proxy hostname is used when this is not set."),
+				restricted: true
+			},
 			'http.proxyAuthorization': {
 				type: ['null', 'string'],
 				default: null,

src/vs/workbench/api/node/proxyResolver.ts

@@ -136,8 +136,7 @@ async function lookupProxyAuthorization(
 			try {
 				const kerberos = await import('kerberos');
 				const url = new URL(proxyURL);
-				// TODO: Add core user setting.
-				const spn = configProvider.getConfiguration('github.copilot')?.advanced?.kerberosServicePrincipal as string | undefined
+				const spn = configProvider.getConfiguration('http').get<string>('proxyKerberosServicePrincipal')
 					|| (process.platform === 'win32' ? `HTTP/${url.hostname}` : `HTTP@${url.hostname}`);
 				extHostLogService.debug('ProxyResolver#lookupProxyAuthorization Kerberos authentication lookup', `proxyURL:${proxyURL}`, `spn:${spn}`);
 				const client = await kerberos.initializeClient(spn);