Merge pull request microsoft#184953 from microsoft/merogge/fix-a-bug

meganrogge · web-flow · commit dfcaefac6c10 · 2023-06-12T16:18:38.000-05:00
prevent repeated event handling
diff --git a/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts b/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts
@@ -105,10 +105,11 @@ class AccessibleView extends Disposable {
 			}
 			container.appendChild(this._editorContainer);
 			this._layout();
-			this._register(this._editorWidget.onKeyDown((e) => {
+			this._register(this._editorWidget.onKeyUp((e) => {
 				if (e.keyCode === KeyCode.Escape) {
 					this._contextViewService.hideContextView();
 				}
+				e.stopPropagation();
 				provider.onKeyDown?.(e);
 			}));
 			this._register(this._editorWidget.onDidBlurEditorText(() => this._contextViewService.hideContextView()));

Original file line number	Diff line number	Diff line change
`@@ -105,10 +105,11 @@ class AccessibleView extends Disposable {`
`105`	`105`	`}`
`106`	`106`	`container.appendChild(this._editorContainer);`
`107`	`107`	`this._layout();`
`108`		`- this._register(this._editorWidget.onKeyDown((e) => {`
	`108`	`+ this._register(this._editorWidget.onKeyUp((e) => {`
`109`	`109`	`if (e.keyCode === KeyCode.Escape) {`
`110`	`110`	`this._contextViewService.hideContextView();`
`111`	`111`	`}`
	`112`	`+ e.stopPropagation();`
`112`	`113`	`provider.onKeyDown?.(e);`
`113`	`114`	`}));`
`114`	`115`	`this._register(this._editorWidget.onDidBlurEditorText(() => this._contextViewService.hideContextView()));`