Add reasons to Terminal log

Author: Tyriar

src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/runInTerminalTool.ts

@@ -172,24 +172,33 @@ export class RunInTerminalTool extends Disposable implements IToolImpl {
 			const inlineSubCommands = subCommands.map(e => Array.from(extractInlineSubCommands(e, shell, os))).flat();
 			const allSubCommands = [...subCommands, ...inlineSubCommands];
 			const subCommandResults = allSubCommands.map(e => this._commandLineAutoApprover.isCommandAutoApproved(e, shell, os));
+			const autoApproveReasons: string[] = [...subCommandResults.map(e => e.reason)];
+
 			if (subCommandResults.every(e => e.isAutoApproved)) {
+				this._logService.info('autoApprove: All sub-commands auto-approved');
 				confirmationMessages = undefined;
 			} else {
+				this._logService.info('autoApprove: All sub-commands NOT auto-approved');
 				const commandLineResults = this._commandLineAutoApprover.isCommandLineAutoApproved(args.command);
+				autoApproveReasons.push(commandLineResults.reason);
 				if (commandLineResults.isAutoApproved) {
+					this._logService.info('autoApprove: Command line auto-approved');
 					confirmationMessages = undefined;
 				} else {
-					// TODO: Surface reason in UI
+					this._logService.info('autoApprove: Command line NOT auto-approved');
 					confirmationMessages = {
 						title: args.isBackground
 							? localize('runInTerminal.background', "Run command in background terminal")
 							: localize('runInTerminal.foreground', "Run command in terminal"),
-						message: new MarkdownString(
-							args.explanation
-						),
+						message: new MarkdownString(args.explanation),
 					};
 				}
 			}
+
+			// TODO: Surface reason on tool part https://github.com/microsoft/vscode/pull/256793
+			for (const reason of autoApproveReasons) {
+				this._logService.info(`- ${reason}`);
+			}
 		}
 
 		const instance = context.chatSessionId ? this._sessionTerminalAssociations.get(context.chatSessionId)?.instance : undefined;

src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalChatAgentToolsConfiguration.ts

@@ -35,7 +35,7 @@ export const terminalChatAgentToolsConfiguration: IStringDictionary<IConfigurati
 			localize('autoApprove.description.intro', "A list of commands or regular expressions that control whether the run in terminal tool commands require explicit approval. These will be matched against the start of a command. A regular expression can be provided by wrapping the string in {0} characters followed by optional flags such as {1} for case-insensitivity.", '`/`', '`i`'),
 			localize('autoApprove.description.values', "Set to {0} to automatically approve commands, {1} to always require explicit approval or {2} to unset the value.", '`true`', '`false`', '`null`'),
 			localize('autoApprove.description.subCommands', "Note that these commands and regular expressions are evaluated for every _sub-command_ within the full _command line_, so {0} for example will need both {1} and {2} to match a {3} entry and must not match a {4} entry in order to auto approve. Inline commands are also detected so {5} will need both {5} and {6} to pass.", '`foo && bar`', '`foo`', '`bar`', '`true`', '`false`', '`echo $(rm file)`', '`rm file`'),
-			localize('autoApprove.description.commandLine', "An object can be used to match against the full command line instead of matching sub-commands and inline commands, for example {0}. This will be checked _after_ sub-commands are checked, so denied sub-commands will take precedence.", '`{ approve: false, matchCommandLine: true }`'),
+			localize('autoApprove.description.commandLine', "An object can be used to match against the full command line instead of matching sub-commands and inline commands, for example {0}. This will be checked _after_ sub-commands are checked, taking precedence over even denied sub-commands.", '`{ approve: false, matchCommandLine: true }`'),
 			[
 				localize('autoApprove.description.examples.title', 'Examples:'),
 				`|${localize('autoApprove.description.examples.value', "Value")}|${localize('autoApprove.description.examples.description', "Description")}|`,