Fix search editor scrolled to bottom on first search when editor group changed. (microsoft#134693)

ssigwart · Jackson Kearl · web-flow · commit e16defc5980b · 2021-10-26T00:30:20.000-07:00
* Fix search editor scrolled to bottom on first search when editor group changed.

* Await model write before setting scroll.

Co-authored-by: Jackson Kearl &lt;jakearl@microsoft.com&gt;
diff --git a/src/vs/workbench/contrib/searchEditor/browser/searchEditor.ts b/src/vs/workbench/contrib/searchEditor/browser/searchEditor.ts
@@ -538,7 +538,7 @@ export class SearchEditor extends BaseTextEditor<SearchEditorViewState> {
 		});
 
 		const searchOperation = await startInput.ongoingSearchOperation;
-		this.onSearchComplete(searchOperation, config, startInput);
+		await this.onSearchComplete(searchOperation, config, startInput);
 	}
 
 	private async onSearchComplete(searchOperation: ISearchComplete, startConfig: SearchConfiguration, startInput: SearchEditorInput) {

Original file line number	Diff line number	Diff line change
`@@ -538,7 +538,7 @@ export class SearchEditor extends BaseTextEditor<SearchEditorViewState> {`
`538`	`538`	`});`
`539`	`539`
`540`	`540`	`const searchOperation = await startInput.ongoingSearchOperation;`
`541`		`- this.onSearchComplete(searchOperation, config, startInput);`
	`541`	`+ await this.onSearchComplete(searchOperation, config, startInput);`
`542`	`542`	`}`
`543`	`543`
`544`	`544`	`private async onSearchComplete(searchOperation: ISearchComplete, startConfig: SearchConfiguration, startInput: SearchEditorInput) {`