voice - make sure speech context counters do not get out of sync (microsoft#213637) (microsoft#213898)

Author: bpasero

src/vs/workbench/contrib/chat/common/voiceChatService.ts

@@ -126,7 +126,7 @@ export class VoiceChatService extends Disposable implements IVoiceChatService {
 		const disposables = new DisposableStore();
 
 		const onSessionStoppedOrCanceled = (dispose: boolean) => {
-			this.activeVoiceChatSessions--;
+			this.activeVoiceChatSessions = Math.max(0, this.activeVoiceChatSessions - 1);
 			if (this.activeVoiceChatSessions === 0) {
 				this.voiceChatInProgress.reset();
 			}

src/vs/workbench/contrib/chat/electron-sandbox/actions/voiceChatActions.ts

@@ -665,7 +665,10 @@ export class StopListeningAndSubmitAction extends Action2 {
 			f1: true,
 			keybinding: {
 				weight: KeybindingWeight.WorkbenchContrib,
-				when: FocusInChatInput,
+				when: ContextKeyExpr.and(
+					FocusInChatInput,
+					AnyScopedVoiceChatInProgress
+				),
 				primary: KeyMod.CtrlCmd | KeyCode.KeyI
 			},
 			precondition: GlobalVoiceChatInProgress // need global context here because of `f1: true`

src/vs/workbench/contrib/speech/browser/speechService.ts

@@ -153,7 +153,7 @@ export class SpeechService extends Disposable implements ISpeechService {
 		const disposables = new DisposableStore();
 
 		const onSessionStoppedOrCanceled = () => {
-			this.activeSpeechToTextSessions--;
+			this.activeSpeechToTextSessions = Math.max(0, this.activeSpeechToTextSessions - 1);
 			if (!this.hasActiveSpeechToTextSession) {
 				this.speechToTextInProgress.reset();
 			}
@@ -264,7 +264,7 @@ export class SpeechService extends Disposable implements ISpeechService {
 		const disposables = new DisposableStore();
 
 		const onSessionStoppedOrCanceled = (dispose: boolean) => {
-			this.activeTextToSpeechSessions--;
+			this.activeTextToSpeechSessions = Math.max(0, this.activeTextToSpeechSessions - 1);
 			if (!this.hasActiveTextToSpeechSession) {
 				this.textToSpeechInProgress.reset();
 			}
@@ -406,7 +406,7 @@ export class SpeechService extends Disposable implements ISpeechService {
 		const disposables = new DisposableStore();
 
 		const onSessionStoppedOrCanceled = () => {
-			this.activeKeywordRecognitionSessions--;
+			this.activeKeywordRecognitionSessions = Math.max(0, this.activeKeywordRecognitionSessions - 1);
 			this._onDidEndKeywordRecognition.fire();
 
 			disposables.dispose();