Timeline - expose timeline item to all extensions that have the proposal enabled (microsoft#238125)

Author: lszomoru

src/vs/workbench/api/common/extHostCommands.ts

@@ -28,7 +28,7 @@ import { VSBuffer } from '../../../base/common/buffer.js';
 import { SerializableObjectWithBuffers } from '../../services/extensions/common/proxyIdentifier.js';
 import { toErrorMessage } from '../../../base/common/errorMessage.js';
 import { StopWatch } from '../../../base/common/stopwatch.js';
-import { ExtensionIdentifier, IExtensionDescription } from '../../../platform/extensions/common/extensions.js';
+import { IExtensionDescription } from '../../../platform/extensions/common/extensions.js';
 import { TelemetryTrustedValue } from '../../../platform/telemetry/common/telemetryUtils.js';
 import { IExtHostTelemetry } from './extHostTelemetry.js';
 import { generateUuid } from '../../../base/common/uuid.js';
@@ -41,7 +41,7 @@ interface CommandHandler {
 }
 
 export interface ArgumentProcessor {
-	processArgument(arg: any, extensionId: ExtensionIdentifier | undefined): any;
+	processArgument(arg: any, extension: IExtensionDescription | undefined): any;
 }
 
 export class ExtHostCommands implements ExtHostCommandsShape {
@@ -310,7 +310,7 @@ export class ExtHostCommands implements ExtHostCommandsShape {
 		if (!cmdHandler) {
 			return Promise.reject(new Error(`Contributed command '${id}' does not exist.`));
 		} else {
-			args = args.map(arg => this._argumentProcessors.reduce((r, p) => p.processArgument(r, cmdHandler.extension?.identifier), arg));
+			args = args.map(arg => this._argumentProcessors.reduce((r, p) => p.processArgument(r, cmdHandler.extension), arg));
 			return this._executeContributedCommand(id, args, true);
 		}
 	}

src/vs/workbench/api/common/extHostTimeline.ts

@@ -16,6 +16,7 @@ import { MarkdownString } from './extHostTypeConverters.js';
 import { ExtensionIdentifier } from '../../../platform/extensions/common/extensions.js';
 import { MarshalledId } from '../../../base/common/marshallingIds.js';
 import { isString } from '../../../base/common/types.js';
+import { isProposedApiEnabled } from '../../services/extensions/common/extensions.js';
 
 export interface IExtHostTimeline extends ExtHostTimelineShape {
 	readonly _serviceBrand: undefined;
@@ -42,7 +43,7 @@ export class ExtHostTimeline implements IExtHostTimeline {
 		commands.registerArgumentProcessor({
 			processArgument: (arg, extension) => {
 				if (arg && arg.$mid === MarshalledId.TimelineActionContext) {
-					if (this._providers.get(arg.source) && ExtensionIdentifier.equals(extension, this._providers.get(arg.source)?.extension)) {
+					if (this._providers.get(arg.source) && extension && isProposedApiEnabled(extension, 'timeline')) {
 						const uri = arg.uri === undefined ? undefined : URI.revive(arg.uri);
 						return this._itemsBySourceAndUriMap.get(arg.source)?.get(getUriKey(uri))?.get(arg.handle);
 					} else {