Only fire collapsible change event if actually changed. (microsoft#213910)

alexr00 · web-flow · commit e545871b48d5 · 2024-05-30T15:49:23.000+02:00
diff --git a/src/vs/workbench/api/browser/mainThreadComments.ts b/src/vs/workbench/api/browser/mainThreadComments.ts
@@ -109,8 +109,10 @@ export class MainThreadCommentThread<T> implements languages.CommentThread<T> {
 	}
 
 	set collapsibleState(newState: languages.CommentThreadCollapsibleState | undefined) {
-		this._collapsibleState = newState;
-		this._onDidChangeCollapsibleState.fire(this._collapsibleState);
+		if (newState !== this._collapsibleState) {
+			this._collapsibleState = newState;
+			this._onDidChangeCollapsibleState.fire(this._collapsibleState);
+		}
 	}
 
 	private _initialCollapsibleState: languages.CommentThreadCollapsibleState | undefined;

Original file line number	Diff line number	Diff line change
`@@ -109,8 +109,10 @@ export class MainThreadCommentThread<T> implements languages.CommentThread<T> {`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`set collapsibleState(newState: languages.CommentThreadCollapsibleState \| undefined) {`
`112`		`- this._collapsibleState = newState;`
`113`		`- this._onDidChangeCollapsibleState.fire(this._collapsibleState);`
	`112`	`+ if (newState !== this._collapsibleState) {`
	`113`	`+ this._collapsibleState = newState;`
	`114`	`+ this._onDidChangeCollapsibleState.fire(this._collapsibleState);`
	`115`	`+ }`
`114`	`116`	`}`
`115`	`117`
`116`	`118`	`private _initialCollapsibleState: languages.CommentThreadCollapsibleState \| undefined;`