Skip to content

Commit e5559ca

Browse files
authored
Add border to walkthrough tiles (microsoft#166661)
* Add border to walkthrough tiles * Update border color for tile and getting started step
1 parent d186d6f commit e5559ca

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStartedColors.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,16 @@
33
* Licensed under the MIT License. See License.txt in the project root for license information.
44
*--------------------------------------------------------------------------------------------*/
55

6-
import { darken, inputBackground, editorWidgetBackground, lighten, registerColor, textLinkForeground } from 'vs/platform/theme/common/colorRegistry';
6+
import { darken, inputBackground, editorWidgetBackground, lighten, registerColor, textLinkForeground, contrastBorder } from 'vs/platform/theme/common/colorRegistry';
77
import { localize } from 'vs/nls';
88

99
// Seprate from main module to break dependency cycles between welcomePage and gettingStarted.
1010
export const welcomePageBackground = registerColor('welcomePage.background', { light: null, dark: null, hcDark: null, hcLight: null }, localize('welcomePage.background', 'Background color for the Welcome page.'));
1111

1212
export const welcomePageTileBackground = registerColor('welcomePage.tileBackground', { dark: editorWidgetBackground, light: editorWidgetBackground, hcDark: '#000', hcLight: editorWidgetBackground }, localize('welcomePage.tileBackground', 'Background color for the tiles on the Get Started page.'));
1313
export const welcomePageTileHoverBackground = registerColor('welcomePage.tileHoverBackground', { dark: lighten(editorWidgetBackground, .2), light: darken(editorWidgetBackground, .1), hcDark: null, hcLight: null }, localize('welcomePage.tileHoverBackground', 'Hover background color for the tiles on the Get Started.'));
14+
export const welcomePageTileBorder = registerColor('welcomePage.tileBorder', { dark: '#ffffff1a', light: '#0000001a', hcDark: contrastBorder, hcLight: contrastBorder }, localize('welcomePage.tileBorder', 'Border color for the tiles on the Get Started page.'));
15+
1416

1517
export const welcomePageProgressBackground = registerColor('welcomePage.progress.background', { light: inputBackground, dark: inputBackground, hcDark: inputBackground, hcLight: inputBackground }, localize('welcomePage.progress.background', 'Foreground color for the Welcome page progress bars.'));
1618
export const welcomePageProgressForeground = registerColor('welcomePage.progress.foreground', { light: textLinkForeground, dark: textLinkForeground, hcDark: textLinkForeground, hcLight: textLinkForeground }, localize('welcomePage.progress.foreground', 'Background color for the Welcome page progress bars.'));

src/vs/workbench/contrib/welcomeGettingStarted/browser/media/gettingStarted.css

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@
271271
font-size: 13px;
272272
box-sizing: border-box;
273273
line-height: normal;
274-
margin: 8px 8px 12px 0;
274+
margin: 8px 8px 8px 0;
275275
padding: 3px 6px 6px;
276276
left: -3px;
277277
text-align: left;
@@ -280,6 +280,7 @@
280280
.monaco-workbench .part.editor>.content .gettingStartedContainer .gettingStartedSlideCategories .getting-started-category {
281281
position: relative;
282282
border-radius: 6px;
283+
border: 1px solid var(--vscode-welcomePage-tileBorder);
283284
overflow: hidden;
284285
}
285286

@@ -322,7 +323,7 @@
322323
}
323324

324325
.monaco-workbench .part.editor>.content .gettingStartedContainer .gettingStartedSlide .getting-started-category .featured {
325-
border-top: 30px solid red;
326+
border-top: 30px solid var(--vscode-activityBarBadge-background);
326327
width: 30px;
327328
box-sizing: border-box;
328329
height: 20px;
@@ -408,7 +409,7 @@
408409

409410
.monaco-workbench .part.editor>.content .gettingStartedContainer .gettingStartedSlideDetails .getting-started-step.expanded {
410411
cursor: default !important;
411-
border: 1px solid var(--vscode-editorWidget-border);
412+
border: 1px solid var(--vscode-welcomePage-tileBorder);
412413
}
413414

414415
.monaco-workbench .part.editor>.content .gettingStartedContainer .gettingStartedSlideDetails .getting-started-step.expanded h3 {
@@ -966,10 +967,6 @@
966967
background-color: var(--vscode-activityBarBadge-background);
967968
}
968969

969-
.monaco-workbench .part.editor>.content .gettingStartedContainer .gettingStartedSlide .getting-started-category .featured {
970-
border-top-color: var(--vscode-activityBarBadge-background);
971-
}
972-
973970
.monaco-workbench .part.editor>.content .gettingStartedContainer .gettingStartedSlide .getting-started-checkbox {
974971
background-color: var(--vscode-checkbox-background) !important;
975972
}

0 commit comments

Comments
 (0)