Skip to content

Commit e81a3a0

Browse files
authored
rename widget: remove trace log to avoid flooding until we unmount the widget from editor correctly (microsoft#226977)
* rename widget: remove trace log to avoid flooding until we unmount the widget from editor correctly * add a fixme & link corresponding issue
1 parent 9e82c4a commit e81a3a0

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/vs/editor/contrib/rename/browser/renameWidget.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,8 @@ export class RenameWidget implements IRenameWidget, IContentWidget, IDisposable
318318
}
319319

320320
afterRender(position: ContentWidgetPositionPreference | null): void {
321-
this._trace('invoking afterRender, position: ', position ? 'not null' : 'null');
321+
// FIXME@ulugbekna: commenting trace log out until we start unmounting the widget from editor properly - https://github.com/microsoft/vscode/issues/226975
322+
// this._trace('invoking afterRender, position: ', position ? 'not null' : 'null');
322323
if (position === null) {
323324
// cancel rename when input widget isn't rendered anymore
324325
this.cancelInput(true, 'afterRender (because position is null)');
@@ -363,7 +364,7 @@ export class RenameWidget implements IRenameWidget, IContentWidget, IDisposable
363364
}
364365

365366
cancelInput(focusEditor: boolean, caller: string): void {
366-
this._trace(`invoking cancelInput, caller: ${caller}, _currentCancelInput: ${this._currentAcceptInput ? 'not undefined' : 'undefined'}`);
367+
// this._trace(`invoking cancelInput, caller: ${caller}, _currentCancelInput: ${this._currentAcceptInput ? 'not undefined' : 'undefined'}`);
367368
this._currentCancelInput?.(focusEditor);
368369
}
369370

0 commit comments

Comments
 (0)