Skip to content

Commit e857eec

Browse files
authored
Revert "debug: log progress in NamedPipeDebugAdapter tests (microsoft#170713)" (microsoft#209060)
This reverts commit 32bb67b. This test hasn't flaked in the last two years, and now the console logs can cause a failure themselves if the test runs slowly. Closes microsoft#209049
1 parent 038cbaa commit e857eec

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

src/vs/workbench/contrib/debug/test/node/streamDebugAdapter.test.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -49,40 +49,28 @@ suite('Debug - StreamDebugAdapter', () => {
4949
ensureNoDisposablesAreLeakedInTestSuite();
5050

5151
test(`StreamDebugAdapter (NamedPipeDebugAdapter) can initialize a connection`, async () => {
52-
// todo@connor4312: debug test failure that seems to only happen in CI.
53-
// Even running this test on a loop on my machine for an hour doesn't hit failures :(
54-
const progress: string[] = [];
55-
const timeout = setTimeout(() => {
56-
console.log('NamedPipeDebugAdapter test might fail. Progress:', progress.join(','));
57-
}, 1000); // should usually finish is <10ms
5852

5953
const pipeName = crypto.randomBytes(10).toString('hex');
6054
const pipePath = platform.isWindows ? join('\\\\.\\pipe\\', pipeName) : join(tmpdir(), pipeName);
61-
progress.push(`listen on ${pipePath}`);
6255
const server = await new Promise<net.Server>((resolve, reject) => {
6356
const server = net.createServer(serverConnection);
6457
server.once('listening', () => resolve(server));
6558
server.once('error', reject);
6659
server.listen(pipePath);
6760
});
68-
progress.push('server up');
6961

7062
const debugAdapter = new NamedPipeDebugAdapter({
7163
type: 'pipeServer',
7264
path: pipePath
7365
});
7466
try {
7567
await debugAdapter.startSession();
76-
progress.push('started session');
7768
const response: DebugProtocol.Response = await sendInitializeRequest(debugAdapter);
78-
progress.push('got response');
7969
assert.strictEqual(response.command, 'initialize');
8070
assert.strictEqual(response.request_seq, 1);
8171
assert.strictEqual(response.success, true, response.message);
8272
} finally {
8373
await debugAdapter.stopSession();
84-
progress.push('stopped session');
85-
clearTimeout(timeout);
8674
server.close();
8775
debugAdapter.dispose();
8876
}

0 commit comments

Comments
 (0)