Skip to content

Commit e87dc37

Browse files
committed
Enable system certificates v2 by default (microsoft#185098)
1 parent 6f21bd8 commit e87dc37

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/vs/workbench/api/node/proxyResolver.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ import { ILogService } from 'vs/platform/log/common/log';
1818
import { IExtensionDescription } from 'vs/platform/extensions/common/extensions';
1919
import { LogLevel, createHttpPatch, createProxyResolver, createTlsPatch, ProxySupportSetting, ProxyAgentParams, createNetPatch } from '@vscode/proxy-agent';
2020

21+
const systemCertificatesV2Default = true;
22+
2123
export function connectProxyResolver(
2224
extHostWorkspace: IExtHostWorkspaceProvider,
2325
configProvider: ExtHostConfigProvider,
@@ -74,12 +76,12 @@ function createPatchedModules(params: ProxyAgentParams, resolveProxy: ReturnType
7476

7577
function certSettingV1(configProvider: ExtHostConfigProvider) {
7678
const http = configProvider.getConfiguration('http');
77-
return !http.get<boolean>('experimental.systemCertificatesV2') && !!http.get<boolean>('systemCertificates');
79+
return !http.get<boolean>('experimental.systemCertificatesV2', systemCertificatesV2Default) && !!http.get<boolean>('systemCertificates');
7880
}
7981

8082
function certSettingV2(configProvider: ExtHostConfigProvider) {
8183
const http = configProvider.getConfiguration('http');
82-
return !!http.get<boolean>('experimental.systemCertificatesV2') && !!http.get<boolean>('systemCertificates');
84+
return !!http.get<boolean>('experimental.systemCertificatesV2', systemCertificatesV2Default) && !!http.get<boolean>('systemCertificates');
8385
}
8486

8587
const modulesCache = new Map<IExtensionDescription | undefined, { http?: typeof http; https?: typeof https }>();

0 commit comments

Comments
 (0)