Skip to content

Commit e9d4044

Browse files
don't proxy encryption service if we have a credentials provider
1 parent e16d9ef commit e9d4044

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/vs/workbench/services/encryption/browser/encryptionService.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { ProxyChannel } from 'vs/base/parts/ipc/common/ipc';
77
import { registerSingleton } from 'vs/platform/instantiation/common/extensions';
88
import { ILogService } from 'vs/platform/log/common/log';
99
import { IEncryptionService } from 'vs/workbench/services/encryption/common/encryptionService';
10-
import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService';
10+
import { IBrowserWorkbenchEnvironmentService } from 'vs/workbench/services/environment/browser/environmentService';
1111
import { IRemoteAgentService } from 'vs/workbench/services/remote/common/remoteAgentService';
1212

1313
export class EncryptionService implements IEncryptionService {
@@ -16,11 +16,11 @@ export class EncryptionService implements IEncryptionService {
1616

1717
constructor(
1818
@IRemoteAgentService remoteAgentService: IRemoteAgentService,
19-
@IWorkbenchEnvironmentService environmentService: IWorkbenchEnvironmentService,
19+
@IBrowserWorkbenchEnvironmentService environmentService: IBrowserWorkbenchEnvironmentService,
2020
@ILogService logService: ILogService
2121
) {
2222
// This allows the remote side to handle any encryption requests
23-
if (environmentService.remoteAuthority) {
23+
if (environmentService.remoteAuthority && !environmentService.options?.credentialsProvider) {
2424
logService.trace('EncryptionService#constructor - Detected remote environment, registering proxy for encryption instead');
2525
return ProxyChannel.toService<IEncryptionService>(remoteAgentService.getConnection()!.getChannel('encryption'));
2626
}

0 commit comments

Comments
 (0)