Skip to content

Commit ea9f1da

Browse files
authored
fix quote type in issue reporter (microsoft#205582)
changed quote type
1 parent efc04b8 commit ea9f1da

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/vs/platform/issue/electron-main/issueMainService.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -459,8 +459,8 @@ export class IssueMainService implements IIssueMainService {
459459
const replyChannel = `vscode:triggerReporterMenu`;
460460
const cts = new CancellationTokenSource();
461461
window.sendWhenReady(replyChannel, cts.token, { replyChannel, extensionId, extensionName });
462-
const result = await raceTimeout(new Promise(resolve => validatedIpcMain.once('vscode:triggerReporterMenuResponse:${extensionId}', (_: unknown, data: IssueReporterData | undefined) => resolve(data))), 5000, () => {
463-
this.logService.error('Error: Extension ${extensionId} timed out waiting for menu response');
462+
const result = await raceTimeout(new Promise(resolve => validatedIpcMain.once(`vscode:triggerReporterMenuResponse:${extensionId}`, (_: unknown, data: IssueReporterData | undefined) => resolve(data))), 5000, () => {
463+
this.logService.error(`Error: Extension ${extensionId} timed out waiting for menu response`);
464464
cts.cancel();
465465
});
466466
return result as IssueReporterData | undefined;

src/vs/workbench/services/issue/electron-sandbox/issueService.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export class NativeIssueService implements IWorkbenchIssueService {
8585
}
8686
}
8787
const result = [this._providers.has(extensionId.toLowerCase()), this._handlers.has(extensionId.toLowerCase())];
88-
ipcRenderer.send('vscode:triggerReporterStatusResponse', result);
88+
ipcRenderer.send(`vscode:triggerReporterStatusResponse`, result);
8989
});
9090
ipcRenderer.on('vscode:triggerReporterMenu', async (event, arg) => {
9191
const extensionId = arg.extensionId;
@@ -108,7 +108,7 @@ export class NativeIssueService implements IWorkbenchIssueService {
108108

109109
if (!this.extensionIdentifierSet.has(extensionId)) {
110110
// send undefined to indicate no action was taken
111-
ipcRenderer.send('vscode:triggerReporterMenuResponse:${extensionId}', undefined);
111+
ipcRenderer.send(`vscode:triggerReporterMenuResponse:${extensionId}`, undefined);
112112
}
113113
menu.dispose();
114114
});
@@ -186,7 +186,7 @@ export class NativeIssueService implements IWorkbenchIssueService {
186186
}, dataOverrides);
187187

188188
if (issueReporterData.extensionId && this.extensionIdentifierSet.has(issueReporterData.extensionId)) {
189-
ipcRenderer.send('vscode:triggerReporterMenuResponse:${issueReporterData.extensionId}', issueReporterData);
189+
ipcRenderer.send(`vscode:triggerReporterMenuResponse:${issueReporterData.extensionId}`, issueReporterData);
190190
this.extensionIdentifierSet.delete(new ExtensionIdentifier(issueReporterData.extensionId));
191191
}
192192
return this.issueMainService.openReporter(issueReporterData);

0 commit comments

Comments
 (0)