eng - make fetchWithRetry more robust (microsoft#184716)

Author: bpasero

build/lib/gulpRemoteSource.js

@@ -44,36 +44,48 @@ export function remote(urls: string[] | string, options: IOptions): es.ThroughSt
 	}));
 }
 
-async function fetchWithRetry(url: string, options: IOptions, retries = 10, retryDelay = 250): Promise<VinylFile> {
+async function fetchWithRetry(url: string, options: IOptions, retries = 10, retryDelay = 1000): Promise<VinylFile> {
 	try {
 		let startTime = 0;
 		if (options.verbose) {
 			log(`Start fetching ${ansiColors.magenta(url)}${retries !== 10 ? `(${10 - retries} retry}` : ''}`);
 			startTime = new Date().getTime();
 		}
-		const response = await fetch(url, options.fetchOptions);
-		if (options.verbose) {
-			log(`Fetch completed: Status ${response.status}. Took ${ansiColors.magenta(`${new Date().getTime() - startTime} ms`)}`);
-		}
-		if (response.ok && (response.status >= 200 && response.status < 300)) {
-			// request must be piped out once created, or we'll get this error: "You cannot pipe after data has been emitted from the response."
-			const contents = options.buffer ? await response.buffer() : response.body.pipe(through2());
-			return new VinylFile({
-				cwd: '/',
-				base: options.base,
-				path: url,
-				contents
+		const controller = new AbortController();
+		const timeout = setTimeout(() => controller.abort(), 30 * 1000);
+		try {
+			const response = await fetch(url, {
+				...options.fetchOptions,
+				signal: controller.signal as any /* Typings issue with lib.dom.d.ts */
 			});
+			if (options.verbose) {
+				log(`Fetch completed: Status ${response.status}. Took ${ansiColors.magenta(`${new Date().getTime() - startTime} ms`)}`);
+			}
+			if (response.ok && (response.status >= 200 && response.status < 300)) {
+				// request must be piped out once created, or we'll get this error: "You cannot pipe after data has been emitted from the response."
+				const contents = options.buffer ? await response.buffer() : response.body.pipe(through2());
+				if (options.buffer && options.verbose) {
+					log(`Fetched response body buffer: ${ansiColors.magenta(`${(contents as Buffer).byteLength} bytes`)}`);
+				}
+				return new VinylFile({
+					cwd: '/',
+					base: options.base,
+					path: url,
+					contents
+				});
+			}
+			throw new Error(`Request ${ansiColors.magenta(url)} failed with status code: ${response.status}`);
+		} finally {
+			clearTimeout(timeout);
 		}
-		throw new Error(`Request ${ansiColors.magenta(url)} failed with status code: ${response.status}`);
 	} catch (e) {
-		if (retries > 0) {
-			await new Promise(c => setTimeout(c, retryDelay));
-			return fetchWithRetry(url, options, retries - 1, retryDelay * 2);
-		}
 		if (options.verbose) {
 			log(`Fetching ${ansiColors.cyan(url)} failed: ${e}`);
 		}
+		if (retries > 0) {
+			await new Promise(resolve => setTimeout(resolve, retryDelay));
+			return fetchWithRetry(url, options, retries - 1, retryDelay);
+		}
 		throw e;
 	}
 }