Disable passing in locale to Electron on macOS (microsoft#167889) (microsoft#167898)

* Disable passing in locale to Electron on macOS

Fixes microsoft#167543

* Update src/main.js

Co-authored-by: Robo <[email protected]>

* Fix comment and apply PR feedback

Co-authored-by: Robo <[email protected]>

Co-authored-by: Raymond Zhao <[email protected]>
Co-authored-by: Robo <[email protected]>

Author: 3 people

src/main.js

@@ -100,15 +100,17 @@ if (locale) {
 }
 
 // Pass in the locale to Electron so that the
-// Windows Control Overlay is rendered correctly on Windows,
-// and so that the traffic lights are rendered properly
-// on macOS when using a custom titlebar.
+// Windows Control Overlay is rendered correctly on Windows.
+// For now, don't pass in the locale on macOS due to
+// https://github.com/microsoft/vscode/issues/167543.
 // If the locale is `qps-ploc`, the Microsoft
 // Pseudo Language Language Pack is being used.
 // In that case, use `en` as the Electron locale.
 
-const electronLocale = (!locale || locale === 'qps-ploc') ? 'en' : locale;
-app.commandLine.appendSwitch('lang', electronLocale);
+if (process.platform === 'win32') {
+	const electronLocale = (!locale || locale === 'qps-ploc') ? 'en' : locale;
+	app.commandLine.appendSwitch('lang', electronLocale);
+}
 
 // Load our code once ready
 app.once('ready', function () {