Skip to content

Commit eb375b5

Browse files
committed
don't dispose of previousCommandMarker
1 parent 5d6ea3f commit eb375b5

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

src/vs/workbench/contrib/terminal/browser/capabilities/commandDetectionCapability.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,6 @@ export class CommandDetectionCapability implements ICommandDetectionCapability {
213213
this._logService.debug('CommandDetectionCapability#onCommandFinished', newCommand);
214214
this._onCommandFinished.fire(newCommand);
215215
}
216-
this._currentCommand.previousCommandMarker?.dispose();
217216
this._currentCommand.previousCommandMarker = this._currentCommand.commandStartMarker;
218217
this._currentCommand = {};
219218
}

src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -815,7 +815,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
815815
description,
816816
id: entry.timestamp.toString(),
817817
command: entry,
818-
buttons: (!entry.endMarker?.isDisposed && !entry.marker?.isDisposed && (entry.endMarker!.line - entry.marker!.line > 0)) ? buttons : undefined
818+
buttons: entry.hasOutput ? buttons : undefined
819819
});
820820
commandMap.add(label);
821821
}

0 commit comments

Comments
 (0)