Fix opening welcome page from Help menu (microsoft#204215)

bhavyaus · web-flow · commit ec291c126878 · 2024-02-03T16:40:50.000-08:00
diff --git a/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.contribution.ts b/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.contribution.ts
@@ -64,7 +64,7 @@ registerAction2(class extends Action2 {
 			const selectedStep = typeof walkthroughID === 'string' ? undefined : walkthroughID.step;
 
 			// We're trying to open the welcome page from the Help menu
-			if (!selectedCategory || !selectedStep) {
+			if (!selectedCategory && !selectedStep) {
 				editorService.openEditor({ resource: GettingStartedInput.RESOURCE });
 				return;
 			}

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ registerAction2(class extends Action2 {`
`64`	`64`	`const selectedStep = typeof walkthroughID === 'string' ? undefined : walkthroughID.step;`
`65`	`65`
`66`	`66`	`// We're trying to open the welcome page from the Help menu`
`67`		`- if (!selectedCategory \|\| !selectedStep) {`
	`67`	`+ if (!selectedCategory && !selectedStep) {`
`68`	`68`	`editorService.openEditor({ resource: GettingStartedInput.RESOURCE });`
`69`	`69`	`return;`
`70`	`70`	`}`