Merge pull request microsoft#136503 from microsoft/hediet/fix-136470

hediet · web-flow · commit ed87590a9a0f · 2021-11-10T15:17:16.000+01:00
Fixes microsoft#136470 by not triggering on change when there was no change.
diff --git a/src/vs/editor/common/model/bracketPairs/bracketPairsImpl.ts b/src/vs/editor/common/model/bracketPairs/bracketPairsImpl.ts
@@ -75,8 +75,10 @@ export class BracketPairs extends Disposable implements IBracketPairs {
 				this.onDidChangeEmitter.fire();
 			}
 		} else {
-			this.cache.clear();
-			this.onDidChangeEmitter.fire();
+			if (this.cache.value) {
+				this.cache.clear();
+				this.onDidChangeEmitter.fire();
+			}
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -75,8 +75,10 @@ export class BracketPairs extends Disposable implements IBracketPairs {`
`75`	`75`	`this.onDidChangeEmitter.fire();`
`76`	`76`	`}`
`77`	`77`	`} else {`
`78`		`- this.cache.clear();`
`79`		`- this.onDidChangeEmitter.fire();`
	`78`	`+ if (this.cache.value) {`
	`79`	`+ this.cache.clear();`
	`80`	`+ this.onDidChangeEmitter.fire();`
	`81`	`+ }`
`80`	`82`	`}`
`81`	`83`	`}`
`82`	`84`