eng: fix selfhost test explorer not always working (microsoft#211276)

connor4312 · web-flow · commit ee0213f6fb63 · 2024-04-24T19:14:25.000+02:00
Fixes microsoft#210878
diff --git a/.vscode/extensions/vscode-selfhost-test-provider/src/testOutputScanner.ts b/.vscode/extensions/vscode-selfhost-test-provider/src/testOutputScanner.ts
@@ -111,12 +111,14 @@ export class TestOutputScanner implements vscode.Disposable {
 		}
 	}
 
-	protected readonly processData = (data: string) => {
+	protected readonly processData = (data: string | Buffer) => {
 		if (this.args) {
 			this.outputEventEmitter.fire(`./scripts/test ${this.args.join(' ')}`);
 			this.args = undefined;
 		}
 
+		data = data.toString();
+
 		try {
 			const parsed = JSON.parse(data.trim()) as unknown;
 			if (parsed instanceof Array && parsed.length === 2 && typeof parsed[0] === 'string') {

Original file line number	Diff line number	Diff line change
`@@ -111,12 +111,14 @@ export class TestOutputScanner implements vscode.Disposable {`
`111`	`111`	`}`
`112`	`112`	`}`
`113`	`113`
`114`		`- protected readonly processData = (data: string) => {`
	`114`	`+ protected readonly processData = (data: string \| Buffer) => {`
`115`	`115`	`if (this.args) {`
`116`	`116`	this.outputEventEmitter.fire(`./scripts/test ${this.args.join(' ')}`);
`117`	`117`	`this.args = undefined;`
`118`	`118`	`}`
`119`	`119`
	`120`	`+ data = data.toString();`
	`121`	`+`
`120`	`122`	`try {`
`121`	`123`	`const parsed = JSON.parse(data.trim()) as unknown;`
`122`	`124`	`if (parsed instanceof Array && parsed.length === 2 && typeof parsed[0] === 'string') {`