add a new (unbound) command to focus and accept the first suggestion (microsoft#174856)

microsoft#173387

Author: jrieken

src/vs/editor/contrib/suggest/browser/suggestController.ts

@@ -907,7 +907,7 @@ registerEditorCommand(new SuggestCommand({
 
 registerEditorCommand(new SuggestCommand({
 	id: 'focusSuggestion',
-	precondition: ContextKeyExpr.and(SuggestContext.Visible, SuggestContext.HasFocusedSuggestion.negate(), ContextKeyExpr.equals('config.editor.suggest.selectQuickSuggestions', false)),
+	precondition: ContextKeyExpr.and(SuggestContext.Visible, SuggestContext.HasFocusedSuggestion.negate()),
 	handler: x => x.focusSuggestion(),
 	kbOpts: {
 		weight: weight,
@@ -918,6 +918,15 @@ registerEditorCommand(new SuggestCommand({
 	},
 }));
 
+registerEditorCommand(new SuggestCommand({
+	id: 'focusAndAcceptSuggestion',
+	precondition: ContextKeyExpr.and(SuggestContext.Visible, SuggestContext.HasFocusedSuggestion.negate()),
+	handler: c => {
+		c.focusSuggestion();
+		c.acceptSelectedSuggestion(true, false);
+	}
+}));
+
 registerEditorCommand(new SuggestCommand({
 	id: 'toggleSuggestionDetails',
 	precondition: ContextKeyExpr.and(SuggestContext.Visible, SuggestContext.HasFocusedSuggestion),

src/vs/editor/contrib/suggest/test/browser/suggestModel.test.ts

@@ -1087,8 +1087,6 @@ suite('SuggestModel - TriggerAndCancelOracle', function () {
 
 		return withOracle(async function (model, editor) {
 
-			// editor.updateOptions({ suggest: { selectQuickSuggestions: 'whenQuickSuggestion' } });
-
 			await assertEvent(model.onDidSuggest, () => {
 				editor.setValue('foo');
 				editor.setSelection(new Selection(1, 4, 1, 4));