Use Lazy for creating diff and preview zone so that they don't block startup (microsoft#185041)

microsoft#185034

Author: jrieken

src/vs/workbench/contrib/inlineChat/browser/inlineChatStrategies.ts

@@ -4,6 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { Event } from 'vs/base/common/event';
+import { Lazy } from 'vs/base/common/lazy';
 import { IDisposable } from 'vs/base/common/lifecycle';
 import { ICodeEditor } from 'vs/editor/browser/editorBrowser';
 import { IBulkEditService } from 'vs/editor/browser/services/bulkEditService';
@@ -347,8 +348,8 @@ export class LiveStrategy extends EditModeStrategy {
 
 export class LivePreviewStrategy extends LiveStrategy {
 
-	private readonly _diffZone: InlineChatLivePreviewWidget;
-	private readonly _previewZone: InlineChatFileCreatePreviewWidget;
+	private readonly _diffZone: Lazy<InlineChatLivePreviewWidget>;
+	private readonly _previewZone: Lazy<InlineChatFileCreatePreviewWidget>;
 
 	constructor(
 		session: Session,
@@ -362,49 +363,49 @@ export class LivePreviewStrategy extends LiveStrategy {
 	) {
 		super(session, editor, widget, contextKeyService, storageService, bulkEditService, editorWorkerService, instaService);
 
-		this._diffZone = instaService.createInstance(InlineChatLivePreviewWidget, editor, session);
-		this._previewZone = instaService.createInstance(InlineChatFileCreatePreviewWidget, editor);
+		this._diffZone = new Lazy(() => instaService.createInstance(InlineChatLivePreviewWidget, editor, session));
+		this._previewZone = new Lazy(() => instaService.createInstance(InlineChatFileCreatePreviewWidget, editor));
 	}
 
 	override dispose(): void {
-		this._diffZone.hide();
-		this._diffZone.dispose();
-		this._previewZone.hide();
-		this._previewZone.dispose();
+		this._diffZone.rawValue?.hide();
+		this._diffZone.rawValue?.dispose();
+		this._previewZone.rawValue?.hide();
+		this._previewZone.rawValue?.dispose();
 		super.dispose();
 	}
 
 	override async renderChanges(response: EditResponse) {
 
 		this._updateSummaryMessage();
 		if (this._diffEnabled) {
-			this._diffZone.show();
+			this._diffZone.value.show();
 		}
 
 		if (response.singleCreateFileEdit) {
-			this._previewZone.showCreation(this._session.wholeRange.value, response.singleCreateFileEdit.uri, await Promise.all(response.singleCreateFileEdit.edits));
+			this._previewZone.value.showCreation(this._session.wholeRange.value, response.singleCreateFileEdit.uri, await Promise.all(response.singleCreateFileEdit.edits));
 		} else {
-			this._previewZone.hide();
+			this._previewZone.value.hide();
 		}
 	}
 
 	override async undoChanges(response: EditResponse): Promise<void> {
-		this._diffZone.lockToDiff();
+		this._diffZone.value.lockToDiff();
 		super.undoChanges(response);
 	}
 
 	protected override _doToggleDiff(): void {
 		const scrollState = StableEditorScrollState.capture(this._editor);
 		if (this._diffEnabled) {
-			this._diffZone.show();
+			this._diffZone.value.show();
 		} else {
-			this._diffZone.hide();
+			this._diffZone.value.hide();
 		}
 		scrollState.restore(this._editor);
 	}
 
 	override hasFocus(): boolean {
-		return super.hasFocus() || this._diffZone.hasFocus() || this._previewZone.hasFocus();
+		return super.hasFocus() || this._diffZone.value.hasFocus() || this._previewZone.value.hasFocus();
 	}
 }