Skip to content

Commit f208526

Browse files
authored
Merge branch 'microsoft:main' into main
2 parents 6690e00 + f58f7bf commit f208526

File tree

4 files changed

+15
-13
lines changed

4 files changed

+15
-13
lines changed

src/vs/base/common/observableImpl/autorun.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ export class AutorunObserver<TChangeSummary = any> implements IObserver, IReader
118118
}
119119

120120
private _runIfNeeded() {
121-
if (this.state === AutorunState.upToDate) {
121+
if (this.state === AutorunState.upToDate || this.disposed) {
122122
return;
123123
}
124124

src/vs/editor/browser/viewParts/minimap/minimap.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ class MinimapLayout {
377377
const partialLine = (scrollTop - viewportStartLineNumberVerticalOffset) / lineHeight;
378378

379379
let sliderTopAligned: number;
380-
if (scrollTop > options.paddingTop) {
380+
if (scrollTop >= options.paddingTop) {
381381
sliderTopAligned = (viewportStartLineNumber - startLineNumber + topPaddingLineCount + partialLine) * minimapLineHeight / pixelRatio;
382382
} else {
383383
sliderTopAligned = (scrollTop / options.paddingTop) * (topPaddingLineCount + partialLine) * minimapLineHeight / pixelRatio;

src/vs/editor/contrib/suggest/browser/suggestWidget.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,9 +237,9 @@ export class SuggestWidget implements IDisposable {
237237
if (typeof item.completion.label !== 'string') {
238238
const { detail, description } = item.completion.label;
239239
if (detail && description) {
240-
label = nls.localize('label.full', '{0}{1}, {2}', label, detail, description);
240+
label = nls.localize('label.full', '{0} {1}, {2}', label, detail, description);
241241
} else if (detail) {
242-
label = nls.localize('label.detail', '{0}{1}', label, detail);
242+
label = nls.localize('label.detail', '{0} {1}', label, detail);
243243
} else if (description) {
244244
label = nls.localize('label.desc', '{0}, {1}', label, description);
245245
}

src/vs/workbench/contrib/files/browser/views/explorerView.ts

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -569,15 +569,17 @@ export class ExplorerView extends ViewPane implements IExplorerView {
569569
const stat = e.element;
570570
let anchor = e.anchor;
571571

572-
// Compressed folders
573-
if (stat) {
574-
const controller = this.renderer.getCompressedNavigationController(stat);
575-
576-
if (controller) {
577-
if (e.browserEvent instanceof KeyboardEvent || isCompressedFolderName(e.browserEvent.target)) {
578-
anchor = controller.labels[controller.index];
579-
} else {
580-
controller.last();
572+
// Adjust for compressed folders (except when mouse is used)
573+
if (DOM.isHTMLElement(anchor)) {
574+
if (stat) {
575+
const controller = this.renderer.getCompressedNavigationController(stat);
576+
577+
if (controller) {
578+
if (e.browserEvent instanceof KeyboardEvent || isCompressedFolderName(e.browserEvent.target)) {
579+
anchor = controller.labels[controller.index];
580+
} else {
581+
controller.last();
582+
}
581583
}
582584
}
583585
}

0 commit comments

Comments
 (0)