Empty notification center requires show notifications to be called twice before it is focused (fix microsoft#188763) (microsoft#188973)

Author: bpasero

src/vs/workbench/browser/parts/notifications/notificationsCenter.ts

@@ -79,8 +79,10 @@ export class NotificationsCenter extends Themable implements INotificationsCente
 		if (this._isVisible) {
 			const notificationsList = assertIsDefined(this.notificationsList);
 
-			// Make visible and focus first
-			notificationsList.show(true /* focus */);
+			// Make visible
+			notificationsList.show();
+
+			// Focus first
 			notificationsList.focusFirst();
 
 			return; // already visible

src/vs/workbench/browser/parts/notifications/notificationsList.ts

@@ -14,7 +14,7 @@ import { INotificationViewItem } from 'vs/workbench/common/notifications';
 import { NotificationsListDelegate, NotificationRenderer } from 'vs/workbench/browser/parts/notifications/notificationsViewer';
 import { CopyNotificationMessageAction } from 'vs/workbench/browser/parts/notifications/notificationsActions';
 import { IContextMenuService } from 'vs/platform/contextview/browser/contextView';
-import { assertIsDefined, assertAllDefined } from 'vs/base/common/types';
+import { assertAllDefined } from 'vs/base/common/types';
 import { NotificationFocusedContext } from 'vs/workbench/common/contextkeys';
 import { Disposable } from 'vs/base/common/lifecycle';
 import { AriaRole } from 'vs/base/browser/ui/aria/aria';
@@ -43,13 +43,8 @@ export class NotificationsList extends Disposable {
 		super();
 	}
 
-	show(focus?: boolean): void {
+	show(): void {
 		if (this.isVisible) {
-			if (focus) {
-				const list = assertIsDefined(this.list);
-				list.domFocus();
-			}
-
 			return; // already visible
 		}
 
@@ -60,12 +55,6 @@ export class NotificationsList extends Disposable {
 
 		// Make visible
 		this.isVisible = true;
-
-		// Focus
-		if (focus) {
-			const list = assertIsDefined(this.list);
-			list.domFocus();
-		}
 	}
 
 	private createNotificationsList(): void {
@@ -221,17 +210,17 @@ export class NotificationsList extends Disposable {
 	}
 
 	focusFirst(): void {
-		if (!this.isVisible || !this.list) {
-			return; // hidden
+		if (!this.list) {
+			return; // not created yet
 		}
 
 		this.list.focusFirst();
 		this.list.domFocus();
 	}
 
 	hasFocus(): boolean {
-		if (!this.isVisible || !this.listContainer) {
-			return false; // hidden
+		if (!this.listContainer) {
+			return false; // not created yet
 		}
 
 		return isAncestor(document.activeElement, this.listContainer);