Skip to content

Commit f3b7aa6

Browse files
committed
Rename shellIntegration API readData -> read
Part of microsoft#145234
1 parent 9cc18d7 commit f3b7aa6

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/vs/workbench/api/common/extHostTerminalShellIntegration.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ class InternalTerminalShellExecution {
238238
get cwd(): URI | undefined {
239239
return that.cwd;
240240
},
241-
readData(): AsyncIterable<string> {
241+
read(): AsyncIterable<string> {
242242
return that._createDataStream();
243243
}
244244
};

src/vscode-dts/vscode.proposed.terminalShellIntegration.d.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,7 @@ declare module 'vscode' {
5757
* console.log(data);
5858
* }
5959
*/
60-
// TODO: read? "data" typically means Uint8Array. What's the encoding of the string? Usage here will typically be checking for substrings
61-
readData(): AsyncIterable<string>;
60+
read(): AsyncIterable<string>;
6261
}
6362

6463
export interface Terminal {

0 commit comments

Comments
 (0)