Merge pull request microsoft#250658 from microsoft/osortega/fix-new-search-editor

Fix for splitting search editor behavior

Author: osortega

src/vs/workbench/contrib/searchEditor/browser/searchEditorInput.ts

@@ -316,21 +316,40 @@ export class SearchEditorInput extends EditorInput {
 			}
 		};
 	}
+
+	override copy(): EditorInput {
+		// Generate a new modelUri for the split editor
+		const newModelUri = URI.from({ scheme: SearchEditorScheme, fragment: `${Math.random()}` });
+		const config = this._cachedConfigurationModel?.config ?? {};
+		const results = this._cachedResultsModel?.getValue() ?? '';
+		// Use the 'rawData' variant and pass modelUri
+		return this.instantiationService.invokeFunction(
+			getOrMakeSearchEditorInput,
+			{ from: 'rawData', config, resultsContents: results, modelUri: newModelUri } as any // modelUri is not in the type, but we handle it below
+		);
+	}
 }
 
 export const getOrMakeSearchEditorInput = (
 	accessor: ServicesAccessor,
 	existingData: (
 		| { from: 'model'; config?: Partial<SearchConfiguration>; modelUri: URI; backupOf?: URI }
-		| { from: 'rawData'; resultsContents: string | undefined; config: Partial<SearchConfiguration> }
+		| { from: 'rawData'; resultsContents: string | undefined; config: Partial<SearchConfiguration>; modelUri?: URI }
 		| { from: 'existingFile'; fileUri: URI })
 ): SearchEditorInput => {
 
 	const storageService = accessor.get(IStorageService);
 	const configurationService = accessor.get(IConfigurationService);
 
 	const instantiationService = accessor.get(IInstantiationService);
-	const modelUri = existingData.from === 'model' ? existingData.modelUri : URI.from({ scheme: SearchEditorScheme, fragment: `${Math.random()}` });
+	let modelUri: URI;
+	if (existingData.from === 'model') {
+		modelUri = existingData.modelUri;
+	} else if (existingData.from === 'rawData' && existingData.modelUri) {
+		modelUri = existingData.modelUri;
+	} else {
+		modelUri = URI.from({ scheme: SearchEditorScheme, fragment: `${Math.random()}` });
+	}
 
 	if (!searchEditorModelFactory.models.has(modelUri)) {
 		if (existingData.from === 'existingFile') {