Skip to content

Commit f409c06

Browse files
committed
Clean up trace logs
1 parent 72fb364 commit f409c06

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

src/vs/platform/terminal/node/terminalProcess.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { IProcessEnvironment, isLinux, isMacintosh, isWindows } from 'vs/base/co
1313
import { URI } from 'vs/base/common/uri';
1414
import { Promises } from 'vs/base/node/pfs';
1515
import { localize } from 'vs/nls';
16-
import { ILogService } from 'vs/platform/log/common/log';
16+
import { ILogService, LogLevel } from 'vs/platform/log/common/log';
1717
import { IProductService } from 'vs/platform/product/common/productService';
1818
import { FlowControlConstants, IShellLaunchConfig, ITerminalChildProcess, ITerminalLaunchError, IProcessProperty, IProcessPropertyMap as IProcessPropertyMap, ProcessPropertyType, TerminalShellType, IProcessReadyEvent, ITerminalProcessOptions, PosixShellType, IProcessReadyWindowsPty } from 'vs/platform/terminal/common/terminal';
1919
import { ChildProcessMonitor } from 'vs/platform/terminal/node/childProcessMonitor';
@@ -353,7 +353,9 @@ export class TerminalProcess extends Disposable implements ITerminalChildProcess
353353
// Allow any trailing data events to be sent before the exit event is sent.
354354
// See https://github.com/Tyriar/node-pty/issues/72
355355
private _queueProcessExit() {
356-
this._logService.trace('TerminalProcess#_queueProcessExit', new Error().stack?.replace(/^Error/, ''));
356+
if (this._logService.getLevel() === LogLevel.Trace) {
357+
this._logService.trace('TerminalProcess#_queueProcessExit', new Error().stack?.replace(/^Error/, ''));
358+
}
357359
if (this._closeTimeout) {
358360
clearTimeout(this._closeTimeout);
359361
}
@@ -418,7 +420,9 @@ export class TerminalProcess extends Disposable implements ITerminalChildProcess
418420
}
419421

420422
shutdown(immediate: boolean): void {
421-
this._logService.trace('TerminalProcess#shutdown', new Error().stack?.replace(/^Error/, ''));
423+
if (this._logService.getLevel() === LogLevel.Trace) {
424+
this._logService.trace('TerminalProcess#shutdown', new Error().stack?.replace(/^Error/, ''));
425+
}
422426
// don't force immediate disposal of the terminal processes on Windows as an additional
423427
// mitigation for https://github.com/microsoft/vscode/issues/71966 which causes the pty host
424428
// to become unresponsive, disconnecting all terminals across all windows.

src/vs/workbench/contrib/terminal/browser/remoteTerminalBackend.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ class RemoteTerminalBackend extends BaseTerminalBackend implements ITerminalBack
165165
}
166166
const ids = Array.from(this._ptys.keys());
167167
const serialized = await this._remoteTerminalChannel.serializeTerminalState(ids);
168-
this._logService.info('remote persistTerminalState serialied', serialized);
169168
this._storageService.store(TerminalStorageKeys.TerminalBufferState, serialized, StorageScope.WORKSPACE, StorageTarget.MACHINE);
170169
}
171170

src/vs/workbench/contrib/terminal/electron-sandbox/localTerminalBackend.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,6 @@ class LocalTerminalBackend extends BaseTerminalBackend implements ITerminalBacke
183183
async persistTerminalState(): Promise<void> {
184184
const ids = Array.from(this._ptys.keys());
185185
const serialized = await this._proxy.serializeTerminalState(ids);
186-
this._logService.info('local persistTerminalState serialied', serialized);
187186
this._storageService.store(TerminalStorageKeys.TerminalBufferState, serialized, StorageScope.WORKSPACE, StorageTarget.MACHINE);
188187
}
189188

0 commit comments

Comments
 (0)