mark private properties that are used in tests as public

We have tests that use any-casts to make private properties accessible (in an untyped way). This fails when private property names are mangled and therefore they should be marked as public

Author: jrieken

src/vs/base/browser/ui/splitview/splitview.ts

@@ -414,7 +414,7 @@ export class SplitView<TLayoutContext = undefined> extends Disposable {
 	private contentSize = 0;
 	private proportions: undefined | number[] = undefined;
 	private viewItems: ViewItem<TLayoutContext>[] = [];
-	private sashItems: ISashItem[] = [];
+	sashItems: ISashItem[] = []; // used in tests
 	private sashDragState: ISashDragState | undefined;
 	private state: State = State.Idle;
 	private inverseAltBehavior: boolean;

src/vs/base/parts/quickinput/browser/quickInput.ts

@@ -540,7 +540,7 @@ class QuickPick<T extends IQuickPickItem> extends QuickInput implements IQuickPi
 		return this._items;
 	}
 
-	private get scrollTop() {
+	get scrollTop() {
 		return this.ui.list.scrollTop;
 	}
 

src/vs/base/parts/quickinput/common/quickInput.ts

@@ -295,6 +295,8 @@ export interface IQuickPick<T extends IQuickPickItem> extends IQuickInput {
 
 	items: ReadonlyArray<T | IQuickPickSeparator>;
 
+	scrollTop: number; // used in tests
+
 	canSelectMany: boolean;
 
 	matchOnDescription: boolean;

src/vs/base/parts/quickinput/test/browser/quickinput.test.ts

@@ -29,7 +29,7 @@ suite('QuickInput', () => { // https://github.com/microsoft/vscode/issues/147543
 	let fixture: HTMLElement, controller: QuickInputController, quickpick: IQuickPick<IQuickPickItem>;
 
 	function getScrollTop(): number {
-		return (quickpick as any).scrollTop;
+		return quickpick.scrollTop;
 	}
 
 	setup(() => {

src/vs/base/test/browser/ui/splitview/splitview.test.ts

@@ -62,7 +62,7 @@ class TestView implements IView<number> {
 }
 
 function getSashes(splitview: SplitView): Sash[] {
-	return (splitview as any).sashItems.map((i: any) => i.sash) as Sash[];
+	return splitview.sashItems.map((i: any) => i.sash) as Sash[];
 }
 
 suite('Splitview', () => {

src/vs/editor/common/model/textModel.ts

@@ -172,7 +172,7 @@ const enum StringOffsetValidationType {
 
 export class TextModel extends Disposable implements model.ITextModel, IDecorationsTreesHost {
 
-	private static readonly MODEL_SYNC_LIMIT = 50 * 1024 * 1024; // 50 MB
+	static _MODEL_SYNC_LIMIT = 50 * 1024 * 1024; // 50 MB,  // used in tests
 	private static readonly LARGE_FILE_SIZE_THRESHOLD = 20 * 1024 * 1024; // 20 MB;
 	private static readonly LARGE_FILE_LINE_COUNT_THRESHOLD = 300 * 1000; // 300K lines
 
@@ -346,7 +346,7 @@ export class TextModel extends Disposable implements model.ITextModel, IDecorati
 			this._isTooLargeForTokenization = false;
 		}
 
-		this._isTooLargeForSyncing = (bufferTextLength > TextModel.MODEL_SYNC_LIMIT);
+		this._isTooLargeForSyncing = (bufferTextLength > TextModel._MODEL_SYNC_LIMIT);
 
 		this._versionId = 1;
 		this._alternativeVersionId = 1;

src/vs/workbench/api/test/browser/mainThreadDocumentsAndEditors.test.ts

@@ -145,10 +145,10 @@ suite('MainThreadDocumentsAndEditors', () => {
 
 	test('ignore huge model', function () {
 
-		const oldLimit = (<any>TextModel).MODEL_SYNC_LIMIT;
+		const oldLimit = TextModel._MODEL_SYNC_LIMIT;
 		try {
 			const largeModelString = 'abc'.repeat(1024);
-			(<any>TextModel).MODEL_SYNC_LIMIT = largeModelString.length / 2;
+			TextModel._MODEL_SYNC_LIMIT = largeModelString.length / 2;
 
 			const model = modelService.createModel(largeModelString, null);
 			assert.ok(model.isTooLargeForSyncing());
@@ -162,16 +162,16 @@ suite('MainThreadDocumentsAndEditors', () => {
 			assert.strictEqual(delta.removedEditors, undefined);
 
 		} finally {
-			(<any>TextModel).MODEL_SYNC_LIMIT = oldLimit;
+			TextModel._MODEL_SYNC_LIMIT = oldLimit;
 		}
 	});
 
 	test('ignore huge model from editor', function () {
 
-		const oldLimit = (<any>TextModel).MODEL_SYNC_LIMIT;
+		const oldLimit = TextModel._MODEL_SYNC_LIMIT;
 		try {
 			const largeModelString = 'abc'.repeat(1024);
-			(<any>TextModel).MODEL_SYNC_LIMIT = largeModelString.length / 2;
+			TextModel._MODEL_SYNC_LIMIT = largeModelString.length / 2;
 
 			const model = modelService.createModel(largeModelString, null);
 			const editor = myCreateTestCodeEditor(model);
@@ -182,7 +182,7 @@ suite('MainThreadDocumentsAndEditors', () => {
 			editor.dispose();
 
 		} finally {
-			(<any>TextModel).MODEL_SYNC_LIMIT = oldLimit;
+			TextModel._MODEL_SYNC_LIMIT = oldLimit;
 		}
 	});
 

src/vs/workbench/contrib/debug/browser/debugSession.ts

@@ -42,7 +42,7 @@ import { IPaneCompositePartService } from 'vs/workbench/services/panecomposite/b
 export class DebugSession implements IDebugSession {
 
 	private _subId: string | undefined;
-	raw: RawDebugSession | undefined; // made public because tests assume this exists
+	raw: RawDebugSession | undefined; // used in tests
 	private initialized = false;
 	private _options: IDebugSessionOptions;
 

src/vs/workbench/contrib/files/common/explorerModel.ts

@@ -83,7 +83,7 @@ export class ExplorerModel implements IDisposable {
 }
 
 export class ExplorerItem {
-	protected _isDirectoryResolved: boolean;
+	_isDirectoryResolved: boolean; // used in tests
 	public isError = false;
 	private _isExcluded = false;
 

src/vs/workbench/contrib/files/test/browser/explorerModel.test.ts

@@ -265,7 +265,7 @@ suite('Files - View Model', function () {
 		const child = new ExplorerItem(URI.file(join('C:\\', '/path/to/foo.html')), fileService, configService, undefined, true, false, false, 'foo.html', Date.now());
 		merge2.removeChild(child);
 		merge2.addChild(child);
-		(<any>merge2)._isDirectoryResolved = true;
+		merge2._isDirectoryResolved = true;
 		ExplorerItem.mergeLocalWithDisk(merge2, merge1);
 		assert.strictEqual(merge1.getChild('foo.html')!.name, 'foo.html');
 		assert.deepStrictEqual(merge1.getChild('foo.html')!.parent, merge1, 'Check parent');