report perf for outputs within size window (microsoft#241728)

Co-authored-by: amunger <>

Author: amunger

src/vs/workbench/contrib/notebook/browser/view/renderers/backLayerWebView.ts

@@ -930,8 +930,8 @@ export class BackLayerWebView<T extends ICommonCellInfo> extends Themable {
 				}
 				case 'notebookPerformanceMessage': {
 					this.notebookEditor.updatePerformanceMetadata(data.cellId, data.executionId, data.duration, data.rendererId);
-					if (data.mimeType && data.outputSize && data.rendererId === 'vscode.builtin-renderer') {
-						this._sendPerformanceData(data.mimeType, data.outputSize, data.duration);
+					if (data.outputSize && data.rendererId === 'vscode.builtin-renderer') {
+						this._sendPerformanceData(data.outputSize, data.duration);
 					}
 					break;
 				}
@@ -951,23 +951,20 @@ export class BackLayerWebView<T extends ICommonCellInfo> extends Themable {
 		return initializePromise.p;
 	}
 
-	private _sendPerformanceData(mimeType: string, outputSize: number, renderTime: number) {
+	private _sendPerformanceData(outputSize: number, renderTime: number) {
 		type NotebookOutputRenderClassification = {
 			owner: 'amunger';
 			comment: 'Track performance data for output rendering';
-			mimeType: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Presentation type of the output.' };
 			outputSize: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Size of the output data buffer.'; isMeasurement: true };
 			renderTime: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Time spent rendering output.'; isMeasurement: true };
 		};
 
 		type NotebookOutputRenderEvent = {
-			mimeType: string;
 			outputSize: number;
 			renderTime: number;
 		};
 
 		const telemetryData = {
-			mimeType,
 			outputSize,
 			renderTime
 		};

src/vs/workbench/contrib/notebook/browser/view/renderers/webviewMessages.ts

@@ -486,7 +486,6 @@ export interface IPerformanceMessage extends BaseToWebviewMessage {
 	readonly duration: number;
 	readonly rendererId: string;
 	readonly outputSize?: number;
-	readonly mimeType?: string;
 }
 
 

src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts

@@ -2733,20 +2733,20 @@ async function webviewPreloads(ctx: PreloadContext) {
 
 			if (!!data.executionId && !!data.rendererId) {
 				let outputSize: number | undefined = undefined;
-				let mimeType: string | undefined = undefined;
 				if (data.content.type === 1 /* extension */) {
 					outputSize = data.content.output.valueBytes.length;
-					mimeType = data.content.output.mime;
 				}
 
-				postNotebookMessage<webviewMessages.IPerformanceMessage>('notebookPerformanceMessage', {
-					cellId: data.cellId,
-					executionId: data.executionId,
-					duration: Date.now() - startTime,
-					rendererId: data.rendererId,
-					outputSize,
-					mimeType
-				});
+				// Only send performance messages for non-empty outputs up to a certain size
+				if (outputSize !== undefined && outputSize > 0 && outputSize < 100 * 1024) {
+					postNotebookMessage<webviewMessages.IPerformanceMessage>('notebookPerformanceMessage', {
+						cellId: data.cellId,
+						executionId: data.executionId,
+						duration: Date.now() - startTime,
+						rendererId: data.rendererId,
+						outputSize
+					});
+				}
 			}
 		}