Merge pull request microsoft#191819 from microsoft/merogge/acc-tab

send `Shift+tab` to the shell

Author: meganrogge

src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

@@ -976,6 +976,13 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
 				return false;
 			}
 
+			// Prevent default when shift+tab is being sent to the terminal to avoid it bubbling up
+			// and changing focus https://github.com/microsoft/vscode/issues/188329
+			if (event.key === 'Tab' && event.shiftKey) {
+				event.preventDefault();
+				return true;
+			}
+
 			// Always have alt+F4 skip the terminal on Windows and allow it to be handled by the
 			// system
 			if (isWindows && event.altKey && event.key === 'F4' && !event.ctrlKey) {

src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleWidget.ts

@@ -118,17 +118,13 @@ export abstract class TerminalAccessibleWidget extends DisposableStore {
 					// On escape, hide the accessible buffer and force focus onto the terminal
 					this.hide(true);
 					break;
-				case KeyCode.Tab:
-					// On tab or shift+tab, hide the accessible buffer and perform the default tab
-					// behavior
-					this.hide();
-					break;
 			}
 		}));
 		this.add(this._editorWidget.onDidFocusEditorText(async () => {
 			this._terminalService.setActiveInstance(this._instance as ITerminalInstance);
 			this._xtermElement.classList.add(ClassName.Hide);
 		}));
+		this.add(this._editorWidget.onDidBlurEditorText(async () => this.hide()));
 	}
 
 	registerListeners(): void {