🐛 Avoid reading truncated property values having '='

babakks · babakks · commit f73201ad7f58 · 2022-08-10T11:46:06.000Z
Signed-off-by: Babak K. Shandiz &lt;babak.k.shandiz@gmail.com&gt;
diff --git a/src/vs/platform/terminal/common/xterm/shellIntegrationAddon.ts b/src/vs/platform/terminal/common/xterm/shellIntegrationAddon.ts
@@ -330,10 +330,11 @@ export class ShellIntegrationAddon extends Disposable implements IShellIntegrati
 				return true;
 			}
 			case VSCodeOscPt.Property: {
-				const [key, rawValue] = args[0].split('=');
-				if (rawValue === undefined) {
+				const [key, ...rawValues] = args[0].split('=');
+				if (!rawValues.length) {
 					return true;
 				}
+				const rawValue = rawValues.join('=');
 				const value = this._deserializeMessage(rawValue);
 				switch (key) {
 					case 'Cwd': {

Original file line number	Diff line number	Diff line change
`@@ -330,10 +330,11 @@ export class ShellIntegrationAddon extends Disposable implements IShellIntegrati`
`330`	`330`	`return true;`
`331`	`331`	`}`
`332`	`332`	`case VSCodeOscPt.Property: {`
`333`		`- const [key, rawValue] = args[0].split('=');`
`334`		`- if (rawValue === undefined) {`
	`333`	`+ const [key, ...rawValues] = args[0].split('=');`
	`334`	`+ if (!rawValues.length) {`
`335`	`335`	`return true;`
`336`	`336`	`}`
	`337`	`+ const rawValue = rawValues.join('=');`
`337`	`338`	`const value = this._deserializeMessage(rawValue);`
`338`	`339`	`switch (key) {`
`339`	`340`	`case 'Cwd': {`