File tree Expand file tree Collapse file tree 2 files changed +3
-2
lines changed
contrib/mergeEditor/browser/view Expand file tree Collapse file tree 2 files changed +3
-2
lines changed Original file line number Diff line number Diff line change @@ -208,7 +208,9 @@ export abstract class AbstractEditorWithViewState<T extends object> extends Edit
208
208
*
209
209
* @param resource the expected `URI` for the view state. This
210
210
* should be used as a way to ensure the view state in the
211
- * editor control is matching the resource expected.
211
+ * editor control is matching the resource expected, for example
212
+ * by comparing with the underlying model (this was a fix for
213
+ * https://github.com/microsoft/vscode/issues/40114).
212
214
*/
213
215
protected abstract computeEditorViewState ( resource : URI ) : T | undefined ;
214
216
Original file line number Diff line number Diff line change @@ -452,7 +452,6 @@ export class MergeEditor extends AbstractTextEditor<IMergeEditorViewState> {
452
452
453
453
protected computeEditorViewState ( resource : URI ) : IMergeEditorViewState | undefined {
454
454
if ( ! isEqual ( this . model ?. result . uri , resource ) ) {
455
- // TODO@bpasero Why not check `input#resource` and don't ask me for "forgein" resources?
456
455
return undefined ;
457
456
}
458
457
const result = this . inputResultView . editor . saveViewState ( ) ;
You can’t perform that action at this time.
0 commit comments