try to get fish prompt to be preserved

Author: meganrogge

src/vs/platform/terminal/node/terminalEnvironment.ts

@@ -176,12 +176,11 @@ export function getShellIntegrationInjection(
 		case 'fish': {
 			// The injection mechanism used for fish is to add a custom dir to $XDG_DATA_DIRS which
 			// is similar to $ZDOTDIR in zsh but contains a list of directories to run from.
-			// const oldDataDirs = env?.XDG_DATA_DIRS ?? '/usr/local/share:/usr/share';
-			// const newDataDir = path.join(appRoot, 'out/vs/workbench/contrib/terminal/browser/media/fish_xdg_data');
-			// envMixin['XDG_DATA_DIRS'] = `${oldDataDirs}:${newDataDir}`;
-			// addEnvMixinPathPrefix(options, envMixin);
-			// return { newArgs: undefined, envMixin };
-			return undefined;
+			const oldDataDirs = env?.XDG_DATA_DIRS ?? '/usr/local/share:/usr/share';
+			const newDataDir = path.join(appRoot, 'out/vs/workbench/contrib/terminal/browser/media/fish_xdg_data');
+			envMixin['XDG_DATA_DIRS'] = `${oldDataDirs}:${newDataDir}`;
+			addEnvMixinPathPrefix(options, envMixin);
+			return { newArgs: undefined, envMixin };
 		}
 		case 'pwsh': {
 			if (!originalArgs || arePwshImpliedArgs(originalArgs)) {

src/vs/workbench/contrib/terminal/browser/media/fish_xdg_data/fish/vendor_conf.d/shellIntegration.fish

@@ -98,9 +98,22 @@ function __vsc_cmd_clear --on-event fish_cancel
 	__vsc_esc D
 end
 
+# Preserve the user's existing prompt, to wrap in our escape sequences.
+function init_vscode_shell_integration
+	echo "$fish_prompt"
+	functions --copy fish_prompt __vsc_fish_prompt
+end
+
 # Sent whenever a new fish prompt is about to be displayed.
 # Updates the current working directory.
 function __vsc_update_cwd --on-event fish_prompt
+	if type -q init_vscode_shell_integration
+		if set -q fish_prompt
+			init_vscode_shell_integration
+			functions --erase init_vscode_shell_integration
+		end
+	end
+
 	__vsc_esc P Cwd=(__vsc_escape_value "$PWD")
 
 	# If a command marker exists, remove it.
@@ -128,9 +141,6 @@ function __vsc_fish_has_mode_prompt -d "Returns true if fish_mode_prompt is defi
 	functions fish_mode_prompt | string match -rvq '^ *(#|function |end$|$)'
 end
 
-# Preserve the user's existing prompt, to wrap in our escape sequences.
-functions --copy fish_prompt __vsc_fish_prompt
-
 # Preserve and wrap fish_mode_prompt (which appears to the left of the regular
 # prompt), but only if it's not defined as an empty function (which is the
 # officially documented way to disable that feature).
@@ -143,14 +153,18 @@ if __vsc_fish_has_mode_prompt
 	end
 
 	function fish_prompt
-		__vsc_fish_prompt
+		if set -q __vsc_fish_prompt
+			__vsc_fish_prompt
+		end
 		__vsc_fish_cmd_start
 	end
 else
 	# No fish_mode_prompt, so put everything in fish_prompt.
 	function fish_prompt
 		__vsc_fish_prompt_start
-		__vsc_fish_prompt
+		if set -q __vsc_fish_prompt
+			__vsc_fish_prompt
+		end
 		__vsc_fish_cmd_start
 	end
 end