Skip to content

Commit fc4a4ce

Browse files
authored
Fix leak in comments widget (microsoft#166016)
Fixes microsoft#165986
1 parent 624f4ac commit fc4a4ce

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

src/vs/workbench/contrib/comments/browser/commentNode.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -494,6 +494,7 @@ export class CommentNode<T extends IRange | ICellRange> extends Disposable {
494494
this.removeCommentEditor();
495495
}, this.themeService);
496496

497+
this._register(this._commentFormActions);
497498
this._commentFormActions.setActions(menu);
498499
}
499500

src/vs/workbench/contrib/comments/browser/commentReply.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,7 @@ export class CommentReply<T extends IRange | ICellRange> extends Disposable {
261261
this.hideReplyArea();
262262
}, this.themeService);
263263

264+
this._register(this._commentFormActions);
264265
this._commentFormActions.setActions(menu);
265266
}
266267

src/vs/workbench/contrib/comments/browser/commentThreadWidget.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ export class CommentThreadWidget<T extends IRange | ICellRange = IRange> extends
9898
this._scopedInstatiationService,
9999
this
100100
) as unknown as CommentThreadBody<T>;
101+
this._register(this._body);
101102

102103
this._styleElement = dom.createStyleSheet(this.container);
103104

0 commit comments

Comments
 (0)