Skip to content

Commit fd1a6dc

Browse files
authored
Merge pull request microsoft#166822 from microsoft/tyriar/166603
Fix public overriding protected in terminal
2 parents f13ea5e + 42ccce8 commit fd1a6dc

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

src/vs/workbench/contrib/codeEditor/browser/find/simpleFindWidget.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,9 +193,9 @@ export abstract class SimpleFindWidget extends Widget {
193193
}
194194
}
195195

196+
public abstract find(previous: boolean): void;
197+
public abstract findFirst(): void;
196198
protected abstract _onInputChanged(): boolean;
197-
protected abstract find(previous: boolean): void;
198-
protected abstract findFirst(): void;
199199
protected abstract _onFocusTrackerFocus(): void;
200200
protected abstract _onFocusTrackerBlur(): void;
201201
protected abstract _onFindInputFocusTrackerFocus(): void;

src/vs/workbench/contrib/terminal/browser/terminalView.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,8 @@ class SingleTerminalTabActionViewItem extends MenuEntryActionViewItem {
382382
}
383383
}
384384

385-
override updateLabel(e?: ITerminalInstance): void {
385+
// eslint-disable-next-line @typescript-eslint/naming-convention
386+
protected override updateLabel(e?: ITerminalInstance): void {
386387
// Only update if it's the active instance
387388
if (e && e !== this._terminalGroupService.activeInstance) {
388389
return;

src/vs/workbench/contrib/webview/browser/webviewFindWidget.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,5 +81,5 @@ export class WebviewFindWidget extends SimpleFindWidget {
8181

8282
protected _onFindInputFocusTrackerBlur() { }
8383

84-
protected findFirst() { }
84+
findFirst() { }
8585
}

0 commit comments

Comments
 (0)