only apply non-empty class name (microsoft#165836)

meganrogge · web-flow · commit fd5edb990654 · 2022-11-08T19:31:22.000-05:00
fix microsoft#165818
diff --git a/src/vs/platform/actions/browser/dropdownWithPrimaryActionViewItem.ts b/src/vs/platform/actions/browser/dropdownWithPrimaryActionViewItem.ts
@@ -49,7 +49,7 @@ export class DropdownWithPrimaryActionViewItem extends BaseActionViewItem {
 		this._primaryAction = new MenuEntryActionViewItem(primaryAction, undefined, _keybindingService, _notificationService, _contextKeyService, _themeService, _contextMenuProvider);
 		this._dropdown = new DropdownMenuActionViewItem(dropdownAction, dropdownMenuActions, this._contextMenuProvider, {
 			menuAsChild: true,
-			classNames: ['codicon', 'codicon-chevron-down', className],
+			classNames: className ? ['codicon', 'codicon-chevron-down', className] : ['codicon', 'codicon-chevron-down'],
 			keybindingProvider: this._options?.getKeyBinding
 		});
 	}

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ export class DropdownWithPrimaryActionViewItem extends BaseActionViewItem {`
`49`	`49`	`this._primaryAction = new MenuEntryActionViewItem(primaryAction, undefined, _keybindingService, _notificationService, _contextKeyService, _themeService, _contextMenuProvider);`
`50`	`50`	`this._dropdown = new DropdownMenuActionViewItem(dropdownAction, dropdownMenuActions, this._contextMenuProvider, {`
`51`	`51`	`menuAsChild: true,`
`52`		`- classNames: ['codicon', 'codicon-chevron-down', className],`
	`52`	`+ classNames: className ? ['codicon', 'codicon-chevron-down', className] : ['codicon', 'codicon-chevron-down'],`
`53`	`53`	`keybindingProvider: this._options?.getKeyBinding`
`54`	`54`	`});`
`55`	`55`	`}`