Skip to content

Commit fec02a7

Browse files
authored
don't bother normalizing ranges from (funky) hunks as they get normalized later anyways. (microsoft#229830)
fixes microsoft/vscode-copilot#8643
1 parent 462abd6 commit fec02a7

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/vs/workbench/contrib/inlineChat/browser/inlineChatSession.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,8 +298,8 @@ export class StashedSession {
298298

299299
function lineRangeAsRange(lineRange: LineRange, model: ITextModel): Range {
300300
return lineRange.isEmpty
301-
? new Range(lineRange.startLineNumber, 1, lineRange.startLineNumber, model.getLineLength(lineRange.startLineNumber))
302-
: new Range(lineRange.startLineNumber, 1, lineRange.endLineNumberExclusive - 1, model.getLineLength(lineRange.endLineNumberExclusive - 1));
301+
? new Range(lineRange.startLineNumber, 1, lineRange.startLineNumber, Number.MAX_SAFE_INTEGER)
302+
: new Range(lineRange.startLineNumber, 1, lineRange.endLineNumberExclusive - 1, Number.MAX_SAFE_INTEGER);
303303
}
304304

305305
export class HunkData {

src/vs/workbench/contrib/inlineChat/test/browser/inlineChatSession.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,11 +200,11 @@ suite('InlineChatSession', function () {
200200

201201
assert.ok(!session.textModel0.equalsTextBuffer(session.textModelN.getTextBuffer()));
202202
assert.strictEqual(hunk.getState(), HunkState.Pending);
203-
assert.ok(hunk.getRangesN()[0].equalsRange({ startLineNumber: 1, startColumn: 1, endLineNumber: 1, endColumn: 7 }));
203+
assert.ok(hunk.getRangesN()[0].equalsRange({ startLineNumber: 1, startColumn: 1, endLineNumber: 1, endColumn: 8 }));
204204

205205
await makeEditAsAi(EditOperation.insert(new Position(1, 3), 'foobar'));
206206
[hunk] = session.hunkData.getInfo();
207-
assert.ok(hunk.getRangesN()[0].equalsRange({ startLineNumber: 1, startColumn: 1, endLineNumber: 1, endColumn: 13 }));
207+
assert.ok(hunk.getRangesN()[0].equalsRange({ startLineNumber: 1, startColumn: 1, endLineNumber: 1, endColumn: 14 }));
208208

209209
inlineChatSessionService.releaseSession(session);
210210

0 commit comments

Comments
 (0)