Skip to content

Commit feff7c8

Browse files
authored
debug: fix closeReadonlyTabsOnEnd not working (microsoft#203500)
The input itself is not readonly, the filesystem is, so this check was always failing. The entire `debug` scheme is readonly, so we don't need to try to replace the check with anything else. This is pretty safe since this code path is only hit when the new setting is enabled. Closes microsoft#197949
1 parent 7f056a7 commit feff7c8

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

src/vs/workbench/contrib/debug/browser/debugService.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -710,10 +710,7 @@ export class DebugService implements IDebugService {
710710

711711
if (this.configurationService.getValue<IDebugConfiguration>('debug').closeReadonlyTabsOnEnd) {
712712
const editorsToClose = this.editorService.getEditors(EditorsOrder.SEQUENTIAL).filter(({ editor }) => {
713-
if (editor.resource?.scheme === DEBUG_SCHEME) {
714-
return editor.isReadonly() && session.getId() === Source.getEncodedDebugData(editor.resource).sessionId;
715-
}
716-
return false;
713+
return editor.resource?.scheme === DEBUG_SCHEME && session.getId() === Source.getEncodedDebugData(editor.resource).sessionId;
717714
});
718715
this.editorService.closeEditors(editorsToClose);
719716
}

0 commit comments

Comments
 (0)