Merge pull request microsoft#238158 from microsoft/tyriar/238157

Share GPU device across editors, access sync when possible

Author: Tyriar

src/vs/editor/browser/gpu/viewGpuContext.ts

@@ -46,7 +46,8 @@ export class ViewGpuContext extends Disposable {
 	readonly canvas: FastDomNode<HTMLCanvasElement>;
 	readonly ctx: GPUCanvasContext;
 
-	readonly device: Promise<GPUDevice>;
+	static device: Promise<GPUDevice>;
+	static deviceSync: GPUDevice | undefined;
 
 	readonly rectangleRenderer: RectangleRenderer;
 
@@ -109,18 +110,23 @@ export class ViewGpuContext extends Disposable {
 
 		this.ctx = ensureNonNullable(this.canvas.domNode.getContext('webgpu'));
 
-		this.device = GPULifecycle.requestDevice((message) => {
-			const choices: IPromptChoice[] = [{
-				label: nls.localize('editor.dom.render', "Use DOM-based rendering"),
-				run: () => this.configurationService.updateValue('editor.experimentalGpuAcceleration', 'off'),
-			}];
-			this._notificationService.prompt(Severity.Warning, message, choices);
-		}).then(ref => this._register(ref).object);
-		this.device.then(device => {
-			if (!ViewGpuContext._atlas) {
-				ViewGpuContext._atlas = this._instantiationService.createInstance(TextureAtlas, device.limits.maxTextureDimension2D, undefined);
-			}
-		});
+		// Request the GPU device, we only want to do this a single time per window as it's async
+		// and can delay the initial render.
+		if (!ViewGpuContext.device) {
+			ViewGpuContext.device = GPULifecycle.requestDevice((message) => {
+				const choices: IPromptChoice[] = [{
+					label: nls.localize('editor.dom.render', "Use DOM-based rendering"),
+					run: () => this.configurationService.updateValue('editor.experimentalGpuAcceleration', 'off'),
+				}];
+				this._notificationService.prompt(Severity.Warning, message, choices);
+			}).then(ref => {
+				ViewGpuContext.deviceSync = ref.object;
+				if (!ViewGpuContext._atlas) {
+					ViewGpuContext._atlas = this._instantiationService.createInstance(TextureAtlas, ref.object.limits.maxTextureDimension2D, undefined);
+				}
+				return ref.object;
+			});
+		}
 
 		const dprObs = observableValue(this, getActiveWindow().devicePixelRatio);
 		this._register(addDisposableListener(getActiveWindow(), 'resize', () => {
@@ -147,8 +153,7 @@ export class ViewGpuContext extends Disposable {
 		}));
 		this.contentLeft = contentLeft;
 
-
-		this.rectangleRenderer = this._instantiationService.createInstance(RectangleRenderer, context, this.contentLeft, this.devicePixelRatio, this.canvas.domNode, this.ctx, this.device);
+		this.rectangleRenderer = this._instantiationService.createInstance(RectangleRenderer, context, this.contentLeft, this.devicePixelRatio, this.canvas.domNode, this.ctx, ViewGpuContext.device);
 	}
 
 	/**

src/vs/editor/browser/viewParts/viewLinesGpu/viewLinesGpu.ts

@@ -92,7 +92,7 @@ export class ViewLinesGpu extends ViewPart implements IViewLines {
 	async initWebgpu() {
 		// #region General
 
-		this._device = await this._viewGpuContext.device;
+		this._device = ViewGpuContext.deviceSync || await ViewGpuContext.device;
 
 		if (this._store.isDisposed) {
 			return;
@@ -650,7 +650,6 @@ export class ViewLinesGpu extends ViewPart implements IViewLines {
 			column++;
 		}
 
-		console.log(lineNumber, column);
 		return new Position(lineNumber, column + 1);
 	}
 }