Skip to content

Commit ff81f6c

Browse files
authored
Remove un-needed use of native privates (microsoft#187518)
For microsoft#186737
1 parent 54b7f42 commit ff81f6c

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

src/vs/editor/contrib/codeAction/browser/codeActionController.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export class CodeActionController extends Disposable implements IEditorContribut
5656

5757
private readonly _resolver: CodeActionKeybindingResolver;
5858

59-
#disposed = false;
59+
private _disposed = false;
6060

6161
constructor(
6262
editor: ICodeEditor,
@@ -91,7 +91,7 @@ export class CodeActionController extends Disposable implements IEditorContribut
9191
}
9292

9393
override dispose() {
94-
this.#disposed = true;
94+
this._disposed = true;
9595
super.dispose();
9696
}
9797

@@ -150,7 +150,7 @@ export class CodeActionController extends Disposable implements IEditorContribut
150150
return;
151151
}
152152

153-
if (this.#disposed) {
153+
if (this._disposed) {
154154
return;
155155
}
156156

src/vs/editor/contrib/codeAction/browser/codeActionModel.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ export class CodeActionModel extends Disposable {
147147
private readonly _onDidChangeState = this._register(new Emitter<CodeActionsState.State>());
148148
public readonly onDidChangeState = this._onDidChangeState.event;
149149

150-
#isDisposed = false;
150+
private _disposed = false;
151151

152152
constructor(
153153
private readonly _editor: ICodeEditor,
@@ -167,17 +167,17 @@ export class CodeActionModel extends Disposable {
167167
}
168168

169169
override dispose(): void {
170-
if (this.#isDisposed) {
170+
if (this._disposed) {
171171
return;
172172
}
173-
this.#isDisposed = true;
173+
this._disposed = true;
174174

175175
super.dispose();
176176
this.setState(CodeActionsState.Empty, true);
177177
}
178178

179179
private _update(): void {
180-
if (this.#isDisposed) {
180+
if (this._disposed) {
181181
return;
182182
}
183183

@@ -228,7 +228,7 @@ export class CodeActionModel extends Disposable {
228228

229229
this._state = newState;
230230

231-
if (!skipNotify && !this.#isDisposed) {
231+
if (!skipNotify && !this._disposed) {
232232
this._onDidChangeState.fire(newState);
233233
}
234234
}

src/vs/workbench/contrib/webviewPanel/browser/webviewWorkbenchService.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,8 @@ function canRevive(reviver: WebviewResolver, webview: WebviewInput): boolean {
120120

121121
export class LazilyResolvedWebviewEditorInput extends WebviewInput {
122122

123-
#resolved = false;
124-
#resolvePromise?: CancelablePromise<void>;
123+
private _resolved = false;
124+
private _resolvePromise?: CancelablePromise<void>;
125125

126126
constructor(
127127
init: WebviewInputInitInfo,
@@ -133,17 +133,17 @@ export class LazilyResolvedWebviewEditorInput extends WebviewInput {
133133

134134
override dispose() {
135135
super.dispose();
136-
this.#resolvePromise?.cancel();
137-
this.#resolvePromise = undefined;
136+
this._resolvePromise?.cancel();
137+
this._resolvePromise = undefined;
138138
}
139139

140140
@memoize
141141
public override async resolve() {
142-
if (!this.#resolved) {
143-
this.#resolved = true;
144-
this.#resolvePromise = createCancelablePromise(token => this._webviewWorkbenchService.resolveWebview(this, token));
142+
if (!this._resolved) {
143+
this._resolved = true;
144+
this._resolvePromise = createCancelablePromise(token => this._webviewWorkbenchService.resolveWebview(this, token));
145145
try {
146-
await this.#resolvePromise;
146+
await this._resolvePromise;
147147
} catch (e) {
148148
if (!isCancellationError(e)) {
149149
throw e;
@@ -158,7 +158,7 @@ export class LazilyResolvedWebviewEditorInput extends WebviewInput {
158158
return;
159159
}
160160

161-
other.#resolved = this.#resolved;
161+
other._resolved = this._resolved;
162162
return other;
163163
}
164164
}

0 commit comments

Comments
 (0)