Fix microsoft#162438 (microsoft#167176)

Author: sandy081

src/vs/workbench/services/views/common/viewContainerModel.ts

@@ -206,6 +206,14 @@ class ViewDescriptorsState extends Disposable {
 			}
 			if (changedStates.length) {
 				this._onDidChangeStoredState.fire(changedStates);
+				// Update the in memory state after firing the event
+				// so that the views can update their state accordingly
+				for (const changedState of changedStates) {
+					const state = this.get(changedState.id);
+					if (state) {
+						state.visibleGlobal = changedState.visible;
+					}
+				}
 			}
 		}
 	}

src/vs/workbench/services/views/test/browser/viewContainerModel.test.ts

@@ -808,4 +808,33 @@ suite('ViewContainerModel', () => {
 		assert.strictEqual(target.elements[1].id, viewDescriptor3.id);
 	}));
 
+	test('newly added view descriptor is hidden if it was toggled hidden in storage before adding', () => runWithFakedTimers<void>({ useFakeTimers: true }, async () => {
+		container = ViewContainerRegistry.registerViewContainer({ id: 'test', title: 'test', ctorDescriptor: new SyncDescriptor(<any>{}) }, ViewContainerLocation.Sidebar);
+		const viewDescriptor: IViewDescriptor = {
+			id: 'view1',
+			ctorDescriptor: null!,
+			name: 'Test View 1',
+			canToggleVisibility: true
+		};
+		storageService.store(getViewsStateStorageId('test.state'), JSON.stringify([{
+			id: viewDescriptor.id,
+			isHidden: false,
+			order: undefined
+		}]), StorageScope.PROFILE, StorageTarget.USER);
+
+		const testObject = viewDescriptorService.getViewContainerModel(container);
+
+		storageService.store(getViewsStateStorageId('test.state'), JSON.stringify([{
+			id: viewDescriptor.id,
+			isHidden: true,
+			order: undefined
+		}]), StorageScope.PROFILE, StorageTarget.USER);
+
+		ViewsRegistry.registerViews([viewDescriptor], container);
+
+		assert.strictEqual(testObject.isVisible(viewDescriptor.id), false);
+		assert.strictEqual(testObject.activeViewDescriptors[0].id, viewDescriptor.id);
+		assert.strictEqual(testObject.visibleViewDescriptors.length, 0);
+	}));
+
 });