readonly - 💄

Author: bpasero

src/vs/workbench/contrib/files/browser/files.contribution.ts

@@ -296,7 +296,7 @@ configurationRegistry.registerConfiguration({
 				'.*': { 'type': 'boolean' }
 			},
 			'default': {},
-			'markdownDescription': nls.localize('filesReadonlyExclude', "Configure paths or [glob patterns](https://code.visualstudio.com/docs/editor/codebasics#_advanced-search-options) to exclude from being marked as read-only if they match as a result of the `#files.readonlyInclude#` setting."),
+			'markdownDescription': nls.localize('filesReadonlyExclude', "Configure paths or [glob patterns](https://code.visualstudio.com/docs/editor/codebasics#_advanced-search-options) to exclude from being marked as read-only if they match as a result of the `#files.readonlyInclude#` setting. Files from readonly file system providers will always be read-only independent of this setting."),
 			'scope': ConfigurationScope.RESOURCE
 		},
 		[FILES_READONLY_FROM_PERMISSIONS_CONFIG]: {

src/vs/workbench/services/filesConfiguration/common/filesConfigurationService.ts

@@ -98,8 +98,8 @@ export class FilesConfigurationService extends Disposable implements IFilesConfi
 
 	private currentHotExitConfig: string;
 
-	private readonly readonlyIncludeMatcher = this._register(new IdleValue(() => this.createMatcher(FILES_READONLY_INCLUDE_CONFIG)));
-	private readonly readonlyExcludeMatcher = this._register(new IdleValue(() => this.createMatcher(FILES_READONLY_EXCLUDE_CONFIG)));
+	private readonly readonlyIncludeMatcher = this._register(new IdleValue(() => this.createReadonlyMatcher(FILES_READONLY_INCLUDE_CONFIG)));
+	private readonly readonlyExcludeMatcher = this._register(new IdleValue(() => this.createReadonlyMatcher(FILES_READONLY_EXCLUDE_CONFIG)));
 	private configuredReadonlyFromPermissions: boolean | undefined;
 
 	private readonly sessionReadonlyOverrides = new ResourceMap<boolean>(resource => this.uriIdentityService.extUri.getComparisonKey(resource));
@@ -126,7 +126,7 @@ export class FilesConfigurationService extends Disposable implements IFilesConfi
 		this.registerListeners();
 	}
 
-	private createMatcher(config: string) {
+	private createReadonlyMatcher(config: string) {
 		const matcher = this._register(new ResourceGlobMatcher(
 			resource => this.configurationService.getValue(config, { resource }),
 			event => event.affectsConfiguration(config),