fix(repo): fix regressions of staring repository and viewing issues by deleted users (#855)

* fix(repo): Use the right repository entity name

* fix(issue): Fix issue screen

* fix(repo): Fill ghost user if the account is deleted

Author: chinesedfan

src/api/schemas/gql-repos.js

@@ -1,17 +1,39 @@
 import { schema } from 'normalizr';
 
+const ghostUser = {
+  login: 'ghost',
+  avatarUrl: 'https://avatars3.githubusercontent.com/u/10137?v=4',
+  type: 'User',
+};
+
+const fillGhostUser = obj => ({
+  ...obj,
+  nodes: obj.nodes.map(node => ({
+    ...node,
+    author: node.author || ghostUser,
+  })),
+});
+
 export const gqlRepoSchema = new schema.Entity(
-  'repos',
+  'gqlRepos',
   {},
   {
     idAttribute: ({ repository }) => {
       return repository.nameWithOwner.toLowerCase();
     },
     processStrategy: ({ repository }) => ({
       ...repository,
+      openIssuesPreview: fillGhostUser(repository.openIssuesPreview),
+      openPullRequestsPreview: fillGhostUser(
+        repository.openPullRequestsPreview
+      ),
+      issues: fillGhostUser(repository.issues),
+      pullRequests: fillGhostUser(repository.pullRequests),
       permissions: {
         admin: repository.viewerPermission === 'ADMIN',
-        push: repository.viewerPermission === 'ADMIN' || repository.viewerPermission === 'WRITE',
+        push:
+          repository.viewerPermission === 'ADMIN' ||
+          repository.viewerPermission === 'WRITE',
       },
       full_name: repository.nameWithOwner,
       webUrl: `https://github.com/${repository.nameWithOwner}`,

src/issue/screens/issue.screen.js

@@ -61,7 +61,7 @@ const mapStateToProps = (state, ownProps) => {
       isPostingComment,
       isDeletingComment,
     },
-    entities: { users, repos, issues, issueTimelineItems },
+    entities: { users, gqlRepos, issues, issueTimelineItems },
     pagination: { REPOS_GET_CONTRIBUTORS, REPOS_GET_ISSUE_TIMELINE },
   } = state;
 
@@ -79,7 +79,7 @@ const mapStateToProps = (state, ownProps) => {
   return {
     locale,
     authUser: user,
-    repository: repos[issueRepository],
+    repository: gqlRepos[issueRepository],
     contributors: (
       REPOS_GET_CONTRIBUTORS[issueRepository] || { ids: [] }
     ).ids.map(id => users[id]),

src/repository/screens/repository.screen.js

@@ -26,13 +26,13 @@ import { getCommits } from '../repository.action';
 const mapStateToProps = (state, ownProps) => {
   const {
     auth: { user, locale },
-    entities: { users, repos },
+    entities: { users, gqlRepos },
     pagination: { REPOS_GET_CONTRIBUTORS },
   } = state;
 
   const repoId = ownProps.navigation.state.params.repoId;
 
-  const repository = repos[repoId];
+  const repository = gqlRepos[repoId];
 
   const contributorsPagination = REPOS_GET_CONTRIBUTORS[repoId] || {
     ids: [],