Skip to content

Commit 0a608ae

Browse files
author
Stephan Dilly
authored
Fix 624 pull offline (#625)
* fix pull being blocked if it fails * update changelog
1 parent e65218d commit 0a608ae

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1616
### Fixed
1717
- push branch to its tracking remote ([#597](https://github.com/extrawurst/gitui/issues/597))
1818
- fixed panic when staging lines involving missing newline eof ([#605](https://github.com/extrawurst/gitui/issues/605))
19+
- fixed pull/fetch deadlocking when it fails ([#624](https://github.com/extrawurst/gitui/issues/624))
1920

2021
## [0.13.0] - 2020-03-15 - Happy Birthday GitUI 🥳
2122

src/components/pull.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ impl PullComponent {
9999
branch: self.branch.clone(),
100100
basic_credential: cred,
101101
})?;
102+
102103
Ok(())
103104
}
104105

@@ -133,6 +134,8 @@ impl PullComponent {
133134
if err.is_empty() {
134135
self.try_ff_merge()?;
135136
} else {
137+
self.pending = false;
138+
self.hide();
136139
self.queue.borrow_mut().push_back(
137140
InternalEvent::ShowErrorMsg(format!(
138141
"fetch failed:\n{}",

0 commit comments

Comments
 (0)