Skip to content

Commit 12b9071

Browse files
author
Stephan Dilly
authored
fix openssl vendoring with new resolver (#775)
* run otool in ci * pin openssl-sys with 'vendored' feature
1 parent 79c17f4 commit 12b9071

File tree

6 files changed

+13
-2
lines changed

6 files changed

+13
-2
lines changed

.github/workflows/cd.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ jobs:
2828
components: clippy
2929

3030
- name: New Resolver
31-
if: matrix.rust != '1.50'
3231
run: |
3332
cargo install cargo-modify --force
3433
cargo modify new-resolver

.github/workflows/ci.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,11 @@ jobs:
7878
run: |
7979
ls -l ./target/release/gitui.exe
8080
81+
- name: Binary dependencies (mac)
82+
if: matrix.os == 'macos-latest'
83+
run: |
84+
otool -L ./target/release/gitui
85+
8186
- name: Build MSI (windows)
8287
if: matrix.os == 'windows-latest'
8388
run: |

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## Unreleased
99

10+
## Fixed
11+
- openssl vendoring broken on macos ([#772](https://github.com/extrawurst/gitui/issues/772))
12+
1013
## [0.16.1] - 2021-06-06
1114

1215
## Added

Cargo.lock

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ build-release:
1515

1616
release-mac: build-release
1717
strip target/release/gitui
18+
otool -L target/release/gitui
1819
mkdir -p release
1920
tar -C ./target/release/ -czvf ./release/gitui-mac.tar.gz ./gitui
2021
ls -lisah ./release/gitui-mac.tar.gz

asyncgit/Cargo.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ keywords = ["git"]
1313

1414
[dependencies]
1515
scopetime = { path = "../scopetime", version = "0.1" }
16-
git2 = { version = "0.13", features = ["vendored-openssl"] }
16+
git2 = "0.13"
17+
# pinning to vendored openssl, using the git2 feature this gets lost with new resolver
18+
openssl-sys = { version = '0.9', features= ["vendored"] }
1719
# git2 = { path = "../../github/git2-rs", features = ["vendored-openssl"]}
1820
# git2 = { git="https://github.com/extrawurst/git2-rs.git", rev="513a8c9", features = ["vendored-openssl"]}
1921
rayon-core = "1.9"

0 commit comments

Comments
 (0)