Skip to content

Commit 4f2e20e

Browse files
author
Stephan Dilly
committed
changelog update
1 parent ce8d798 commit 4f2e20e

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1414
### Fixed
1515

1616
- selection error in stashlist when deleting last element ([#223](https://github.com/extrawurst/gitui/issues/223))
17+
- git hooks broke ci build on windows [[@dr-BEat](https://github.com/dr-BEat)] ([#235](https://github.com/extrawurst/gitui/issues/235))
1718

1819
## [0.9.1] - 2020-07-30
1920

asyncgit/src/sync/hooks.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,13 @@ fn run_hook(
105105
let output = Command::new("bash")
106106
.args(bash_args)
107107
.current_dir(path)
108-
.env("DUMMYENV", "FixPathHandlingOnWindows") // This call forces Command to handle the Path environment correctly on windows, the specific env set here does not matter
108+
// This call forces Command to handle the Path environment correctly on windows,
109+
// the specific env set here does not matter
110+
// see https://github.com/rust-lang/rust/issues/37519
111+
.env(
112+
"DUMMY_ENV_TO_FIX_WINDOWS_CMD_RUNS",
113+
"FixPathHandlingOnWindows",
114+
)
109115
.output();
110116

111117
let output = output.expect("general hook error");

0 commit comments

Comments
 (0)