Skip to content

Commit c86a51c

Browse files
author
Stephan Dilly
committed
allow style to be readable on light themes aswell
1 parent 8ae3caa commit c86a51c

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

src/tabs/revlog/mod.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ impl Revlog {
159159
theme: &Theme,
160160
) {
161161
let count_before = txt.len();
162+
txt.reserve(ELEMENTS_PER_LINE);
162163

163164
let splitter_txt = Cow::from(" ");
164165
let splitter =

src/ui/style.rs

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,9 @@ impl Theme {
7171
match (enabled, selected) {
7272
(false, _) => Style::default().fg(self.disabled_fg),
7373
(true, false) => Style::default(),
74-
(true, true) => Style::default().bg(self.selection_bg),
74+
(true, true) => Style::default()
75+
.fg(self.command_fg)
76+
.bg(self.selection_bg),
7577
}
7678
}
7779

@@ -123,10 +125,14 @@ impl Theme {
123125
DiffLineType::Delete => {
124126
Style::default().fg(self.diff_line_delete)
125127
}
126-
DiffLineType::Header => {
127-
Style::default().modifier(Modifier::BOLD)
128-
}
129-
_ => Style::default(),
128+
DiffLineType::Header => Style::default()
129+
.fg(self.disabled_fg)
130+
.modifier(Modifier::BOLD),
131+
_ => Style::default().fg(if selected {
132+
self.command_fg
133+
} else {
134+
Color::Reset
135+
}),
130136
};
131137

132138
self.apply_select(style, selected)
@@ -217,7 +223,7 @@ impl Default for Theme {
217223
diff_file_added: Color::LightGreen,
218224
diff_file_removed: Color::LightRed,
219225
diff_file_moved: Color::LightMagenta,
220-
diff_file_modified: Color::LightYellow,
226+
diff_file_modified: Color::Yellow,
221227
commit_hash: Color::Magenta,
222228
commit_time: Color::Blue,
223229
commit_author: Color::Green,

0 commit comments

Comments
 (0)