only valid unicode paths are accepted on windows

Author: Joshix-1

asyncgit/src/sync/hooks.rs

@@ -87,16 +87,6 @@ mod tests {
 
 		os_string.push("gitui $# ' ");
 
-		#[cfg(windows)]
-		{
-			use std::os::windows::ffi::OsStringExt;
-
-			const INVALID_UTF16: &[u16] = &[0xD83D];
-
-			os_string.push(OsString::from_wide(INVALID_UTF16));
-
-			assert!(os_string.to_str().is_none());
-		}
 		#[cfg(target_os = "linux")]
 		{
 			use std::os::unix::ffi::OsStrExt;

git2-hooks/src/hookspath.rs

@@ -1,4 +1,4 @@
-use git2::Repository;
+use git2::{IntoCString, Repository};
 
 use crate::{error::Result, HookResult, HooksError};
 
@@ -146,27 +146,7 @@ impl HookPaths {
 				if let Some(hook) = hook.to_str() {
 					os_str.push(hook.replace('\'', REPLACEMENT));
 				} else {
-					#[cfg(windows)]
-					{
-						use std::os::windows::ffi::{
-							OsStrExt, OsStringExt,
-						};
-
-						let mut new_str: Vec<u16> = vec![];
-
-						for ch in hook.as_os_str().encode_wide() {
-							if ch == (b'\'' as u16) {
-								new_str.extend(
-									std::ffi::OsStr::new(REPLACEMENT)
-										.encode_wide(),
-								);
-							} else {
-								new_str.push(ch);
-							}
-						}
-
-						os_str.push(OsString::from_wide(&new_str));
-					}
+					return Err(HooksError::PathToString);
 				}
 				os_str.push("'");
 				os_str.push(" \"$@\"");